hotfix: remove storybook types build and add its own tsconfig #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2023 16:33
…ok from included types in build
ckifer
commented
Feb 10, 2023
| "jsx": "react", | ||
| "module": "commonjs", | ||
| "noImplicitAny": true, | ||
| "noEmit": true, |
There was a problem hiding this comment.
don't emit for the storybook
| "allowSyntheticDefaultImports": true, | ||
| "baseUrl": "." | ||
| }, | ||
| "include": ["./stories"] |
There was a problem hiding this comment.
only include stories folder in this subfolder
| @@ -15,5 +15,5 @@ | |||
| "allowSyntheticDefaultImports": true, | |||
| "baseUrl": "." | |||
| }, | |||
| "include": ["./src/**/*", "types.d.ts", "storybook/stories"] | |||
| "include": ["./src/**/*", "types.d.ts"] | |||
There was a problem hiding this comment.
don't include storybook
we want types folder to be flat rather than
- src/index
- storybook/*
ckifer
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking change in 2.4.0 where
typekey is no longer referencing the correct type index fileRelated Issue
#3353
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: