fix: refactor curve to defaultParams #3671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix latest React throwing error due to using defaultParams in function component within
Curve
. This is not at risk of breaking like other elements referenced in calls to thefindAllByType
, etc. functions inReactUtils
- the list of risky elements is in linked issue #3615 (comment)Related Issue
#3615
Fixes one of a few occurrences of this error being logged
Motivation and Context
Continues to address a highly trafficked issue
How Has This Been Tested?
findAllByType
to see if Curve was referenced, it wasn't - see comment Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead. at {Component} #3615 (comment)Screenshots (if appropriate):
Types of changes
Checklist: