Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor curve to defaultParams #3671

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

ckifer
Copy link
Member

@ckifer ckifer commented Jul 27, 2023

Description

Fix latest React throwing error due to using defaultParams in function component within Curve. This is not at risk of breaking like other elements referenced in calls to the findAllByType, etc. functions in ReactUtils - the list of risky elements is in linked issue #3615 (comment)

Related Issue

#3615

Fixes one of a few occurrences of this error being logged

Motivation and Context

Continues to address a highly trafficked issue

How Has This Been Tested?

Screenshots (if appropriate):

  • N/A - no visual diff

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ckifer ckifer merged commit 85dd29f into recharts:master Jul 27, 2023
5 checks passed
@ckifer ckifer deleted the defaultParams/curve branch July 27, 2023 13:22
@nikolasrieble nikolasrieble removed their request for review September 22, 2023 16:53
GMer78 pushed a commit to GMer78/recharts-1 that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants