Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storybook-addon-performance #3826

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Add storybook-addon-performance #3826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4679be2
Add storybook-addon-performance
PavelVanecek Oct 8, 2023
818103b
Make a change so that github will pick up the new commit maybe
PavelVanecek Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ _Before_ submitting a pull request, please make sure the following is done…
## <a name="code"></a>Code Guide

Our linter will catch most styling issues that may exist in your code.
You can check the status of your code styling by simply running: `npm run lint`
You can check the status of your code styling by running: `npm run lint`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love small language cleanups, thank you!


However, there are still some styles that the linter cannot pick up. If you are unsure about something, looking at [Airbnb's Style Guide](https://github.com/airbnb/javascript) will guide you in the right direction.

Expand Down
118 changes: 118 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@
"reassure": "^0.9.1",
"rimraf": "^3.0.2",
"storybook": "^7.4.6",
"storybook-addon-performance": "^0.17.1",
"terser-webpack-plugin": "^5.1.1",
"ts-jest": "^27.1.5",
"ts-loader": "^8.0.12",
Expand Down
1 change: 1 addition & 0 deletions storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ module.exports = {
'@storybook/addon-a11y',
'@storybook/addon-storysource',
'@storybook/addon-docs',
'storybook-addon-performance',
],
framework: {
name: '@storybook/react-webpack5',
Expand Down
4 changes: 4 additions & 0 deletions storybook/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { Preview } from '@storybook/react';
import './global.css';
import { DocsPage, DocsContainer } from '@storybook/addon-docs';
// eslint-disable-next-line import/no-extraneous-dependencies
import { withPerformance } from 'storybook-addon-performance';

const preview: Preview = {
parameters: {
Expand All @@ -25,3 +27,5 @@ const preview: Preview = {
};

export default preview;

export const decorators = [withPerformance];