Customized stories - 3740 #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolasrieble
requested changes
Oct 15, 2023
There was a problem hiding this comment.
Thank you for picking this up.
The story you found is based on an old example, we initially just copied it. could you please also clean it up? Given that in the API section we want to document the API of each component, I believe exposing the data in the Args is misleading.
Please adapt the story so that the control does not include the data.
Shashangbhagat
force-pushed
the
customized-story-3740
branch
from
d0040fa
to
b5d1e39
Compare
ckifer
approved these changes
Oct 23, 2023
|
|
||
| ## Parent Component | ||
|
|
||
| The Customized can be used within: `<LineChart />`, `<BarChart />`, `<ComposedChart />`, `<AreaChart />`, `<PieChart />`, `<RadarChart />`, `<RadialBarChart />`, `<ScatterChart />` or `<FunnelChart />`. |
There was a problem hiding this comment.
nit, wording: "The" here can be omitted
GMer78
pushed a commit
to GMer78/recharts-1
that referenced
this pull request
Nov 24, 2023
<!--- Provide a general summary of your changes in the Title above --> ## Description I think we already have Customized story but on wrong path, So I updated the path for that. <!--- Describe your changes in detail --> ## Related Issue Issue: [3740](recharts#3740) <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [x] I have added a storybook story or extended an existing story to show my changes - [x] All new and existing tests passed. Co-authored-by: Shashang Bhagat <shashangbhagat@gamil.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think we already have Customized story but on wrong path, So I updated the path for that.
Related Issue
Issue: 3740
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: