Remove unit test that was comparing new/old reduce-css-calc #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? It's not testing anything - it throws, and the error is not reported as a failing test but instead as a log message in the console. Instead I have replaced it with a `.not.toThrow()` call which at least tests that our new implementation is correct. The old one throws so I removed it completely.
PavelVanecek
commented
Oct 16, 2023
| if (!(prevCalc.includes('calc') || prevCalc.includes(' '))) { | ||
| expect(prevCalc).toEqual(newCalc); | ||
| } | ||
| } catch (e) { |
There was a problem hiding this comment.
Test failures from expect are reported as an exception - so this catch turns this test into an always green one. Don't catch exceptions in tests.
There was a problem hiding this comment.
Some of the tests were added to explicitly show that the old reduce css calc threw errors in those cases, but agreed should be maybe been a separate block with expect to throw
ckifer
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? It's not testing anything - it throws, and the error is not reported as a failing test but instead as a log message in the console.
Instead I have replaced it with a
.not.toThrow()call which at least tests that our new implementation doesn't throw. The old one throws so I removed it completely.Description
Related Issue
#3820
Motivation and Context
How Has This Been Tested?
Jest
Screenshots (if appropriate):
Types of changes
Checklist: