Tooltip translate tests #3872
Merged
Tooltip translate tests #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PavelVanecek mind fixing the merge conflict? will merge after |
PavelVanecek
force-pushed
the
tooltip-translate-tests
branch
from
1c26e4e
to
246ece7
Compare
ckifer
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wanted to have unit tests for the translate functions because something broke in it when I was working on the PoC. To make it easier to write those tests I moved the function to separate file and broken down a little bit. But mostly it's just copy-pasting code.
Related Issue
#3823
Motivation and Context
Tests!
How Has This Been Tested?
Jest, TS, Storybook
Screenshots (if appropriate):
Types of changes
Checklist: