Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2589 #3893

Merged
merged 1 commit into from Oct 23, 2023
Merged

Fix #2589 #3893

merged 1 commit into from Oct 23, 2023

Conversation

HHongSeungWoo
Copy link
Member

@HHongSeungWoo HHongSeungWoo commented Oct 22, 2023 •
edited

Description

While not a fundamental solution, it will better utilize caching.

Related Issue

#2589

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or extended an existing story to show my changes
  • All new and existing tests passed.

@HHongSeungWoo HHongSeungWoo changed the title optimize Fix #2589 Oct 22, 2023
ckifer
ckifer requested changes Oct 22, 2023
View reviewed changes
src/util/DOMUtils.ts Show resolved Hide resolved
src/util/DOMUtils.ts Show resolved Hide resolved
@ckifer ckifer merged commit c72860e into recharts:master Oct 23, 2023
5 checks passed
@HHongSeungWoo HHongSeungWoo deleted the fix/2589 branch October 23, 2023 09:11
GMer78 pushed a commit to GMer78/recharts-1 that referenced this pull request Nov 24, 2023
@HHongSeungWoo
Fix recharts#2589 (recharts#3893)
706a726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckifer ckifer ckifer approved these changes

@nikolasrieble nikolasrieble nikolasrieble left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HHongSeungWoo @ckifer @nikolasrieble