Add AccessibilityLater button story with a button #3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case is already present in a spec.tsx file but I also want it in a storybook to better understand why my changes in the PoC branch broke the accessibilityLater
storybook/stories/Examples/ComposedChart/AccessibilityLayer.stories.tsx
Outdated
Show resolved
Hide resolved
…ories.tsx Co-authored-by: Nikolas Rieble <nikolas-rieble@protonmail.com>
|
It's a reproduction case to make sure that if a tooltip is created via accessibility later (i.e. keyboard events instead of a mouse) and then removed from DOM, it will actually disappear from the SVG as well. It just so happens that my PoC branch broke this test too so I want to have a story to be able to debug. |
ckifer
approved these changes
Oct 30, 2023
|
Doesn't hurt anything to add this so going to go for it |
GMer78
pushed a commit
to GMer78/recharts-1
that referenced
this pull request
Nov 24, 2023
This case is already present in a spec.tsx file but I also want it in a storybook to better understand why my changes in the PoC branch broke the accessibilityLater ## Description Added storybook example ## Related Issue ## Motivation and Context ## How Has This Been Tested? `npm run storybook` ## Screenshots (if appropriate): <img width="953" alt="image" src="https://github.com/recharts/recharts/assets/1100170/4571a95c-fc8e-4b1b-af50-eca6efb2a375"> ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - [X] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [X] I have added a storybook story or extended an existing story to show my changes - [X] All new and existing tests passed. --------- Co-authored-by: Nikolas Rieble <nikolas-rieble@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This case is already present in a spec.tsx file but I also want it in a storybook to better understand why my changes in the PoC branch broke the accessibilityLater
Description
Added storybook example
Related Issue
Motivation and Context
How Has This Been Tested?
npm run storybookScreenshots (if appropriate):
Types of changes
Checklist: