Fixed the initial mount re-rendering bug in ResponsiveContainer #3918
Conversation
| setSizes(prevState => { | ||
| const roundedWidth = Math.round(newWidth); | ||
| const roundedHeight = Math.round(newHeight); | ||
| if (prevState.containerWidth === roundedWidth && prevState.containerHeight === roundedHeight) { |
There was a problem hiding this comment.
I guess I only see a slight chance of this happening no? And if the previous state is the same as the new state what's wrong with just not checking this and returning the new state?
There was a problem hiding this comment.
If this is not done, the state would always change, right?
In line 89, we always create a new object.
There was a problem hiding this comment.
Wouldn't it most likely always change anyways? This only helps if I resize the screen and move it to the exact height and width pixels it was before. Though I might be mistaken - it definitely doesn't hurt to be here, more curious than anything
There was a problem hiding this comment.
In browsers that support sub-pixels, values may differ due to precision issues.
Therefore, I compared the values, and if they were the same, I returned the previous state as is to prevent re-rendering
There was a problem hiding this comment.
Gotcha thanks. It's a mini optimization imo but again, doesn't hurt to be here
…arts#3918) <!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [ ] I have added a storybook story or extended an existing story to show my changes - [x] All new and existing tests passed.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: