fix: Line never checks for new totalLength on component update

[ckifer]

Description

getTotalLength only gets called on initial render in Line. When hiding and showing Line components in a specific chart the total length remains the same as it was before, when in fact it is now different (chart adjusts based on available space). In some cases this leads to the charts strokeDasharray not being correct and sometimes partially showing during animation. See videos

Related Issue

fixes #3359

Motivation and Context

Fix bug

How Has This Been Tested?

See videos

• add storybook entry for toggling Line components via Legend click

Before

BeforeRecharts.mp4

After

After_Recharts.mp4

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• I have added a storybook story or extended an existing story to show my changes
• All new and existing tests passed.

[ckifer]

@HHongSeungWoo

[HHongSeungWoo]

This part feels redundant. Since the null case does not exist and it's a primitive type, it seems fine to use this.setState({ totalLength: this.getTotalLength() });

[ckifer]

Right because getTotalLength has a try catch and returns 0 if not found.

But there still is a case (often) where they are the same. I'd rather not call setState if they are.

I'll remove the null check

[HHongSeungWoo]

The tooltip inherits PureComponent, it already performs shallow comparisons.
Primitive type references always remain the same, so it won't rerender, but not calling it explicitly also seems good