Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Cleanup and simplify Tooltip stories #3952

Merged
merged 2 commits into from Nov 12, 2023

Conversation

nikolasrieble
Copy link
Contributor

@nikolasrieble nikolasrieble commented Nov 12, 2023

Description

(1) There were two Tooltip stories in the API section - there should only be one. Moved extra stories in the Example section.
(2) Stories should be as simple as possible -> Use the standard dataset, and remove unneeded logic.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or extended an existing story to show my changes
  • All new and existing tests passed.

@@ -260,37 +259,3 @@ export const API = {
useTranslate3d: false,
},
};

export const LargeDataArray = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved into Example section.

@ckifer ckifer merged commit 60a72bb into master Nov 12, 2023
10 of 11 checks passed
@ckifer ckifer deleted the nikolas.storybook.tooltip branch November 12, 2023 23:06
GMer78 pushed a commit to GMer78/recharts-1 that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants