Fix default parameters for setDetails() #4079
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a small bug fix for how the default parameters are handled in
setDetails()
function. With the existing implementation, it is possible thatthis.coordinateList
gets overridden with[]
since it is not a nullish value.Related Issue
#4052
Motivation and Context
This fix will make accessibility layer
How Has This Been Tested?
Unit tests are passing and Storybook story works as expected. Change is rather small so I'm not sure if a unit test for reproducing the issue is needed (it was a bit of a corner case anyways), but let me know if the tests should also be updated.
Types of changes
Checklist: