Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default parameters for setDetails() #4079

Merged
merged 1 commit into from Jan 25, 2024

Conversation

dahlie
Copy link
Contributor

@dahlie dahlie commented Jan 25, 2024

Description

This PR is a small bug fix for how the default parameters are handled in setDetails() function. With the existing implementation, it is possible that this.coordinateList gets overridden with [] since it is not a nullish value.

Related Issue

#4052

Motivation and Context

This fix will make accessibility layer

How Has This Been Tested?

Unit tests are passing and Storybook story works as expected. Change is rather small so I'm not sure if a unit test for reproducing the issue is needed (it was a bit of a corner case anyways), but let me know if the tests should also be updated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or extended an existing story to show my changes
  • All new and existing tests passed.

Copy link
Member

@ckifer ckifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@ckifer ckifer merged commit 662eccb into recharts:master Jan 25, 2024
5 checks passed
@dahlie dahlie deleted the fix-default-args-for-set-details branch January 26, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants