Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ResponsiveContainer ref hack #4186

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

ckifer
Copy link
Member

@ckifer ckifer commented Feb 13, 2024

Description

remove hack added in #4008 to avoid breaking change

Related Issue

N/A

Motivation and Context

3.x, do all breaking changes now

How Has This Been Tested?

  • npm test
  • confirm this is the correct way for ref to be surfaced

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or extended an existing story to show my changes
  • All new and existing tests passed.

@ckifer ckifer added the breaking change Use this label to indicate a breaking change in the Recharts API label Feb 13, 2024
Copy link
Member

@HHongSeungWoo HHongSeungWoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ckifer ckifer merged commit 36470e1 into 3.x Feb 13, 2024
8 checks passed
@ckifer ckifer deleted the breaking-responsive-container-ref branch February 13, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Use this label to indicate a breaking change in the Recharts API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants