fix: legend size, use offset height and width

[ckifer]

Description

Same PR as
#4272
but for 3.x

• use offset height and width for legend bounding box to prevent scaling issues

Related Issue

#4246

Motivation and Context

#4246

How Has This Been Tested?

• storybook visually
• uni test

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• I have added a storybook story or extended an existing story to show my changes

[ckifer]

unsure why all of these changed to be honest...

[PavelVanecek]

Is it because the cleanup function from mockHTMLElementProperty is never called? Best to do that in afterEach. Check out the restoreGetBoundingClientRect and how it's used.

[ckifer]

fixed, oops.

So in an afterEach doesn't work well unless we want to make the mock specific for offsetHeight and offsetWidth. I tried restoring the entire HTMLElement.prototype but that didn't seem to work.

I'm sure there's a better way but not enough time to get there at least atm :P

[ckifer]

@zhonglin94 fyi

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (408f050) to head (a75a81b).
Report is 3 commits behind head on 3.x.

Additional details and impacted files

@@            Coverage Diff             @@
##              3.x    #4307      +/-   ##
==========================================
+ Coverage   94.68%   94.73%   +0.04%     
==========================================
  Files          92       92              
  Lines       20114    20116       +2     
  Branches     2810     2809       -1     
==========================================
+ Hits        19045    19056      +11     
+ Misses       1063     1054       -9     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[PavelVanecek]

Is it because the cleanup function from mockHTMLElementProperty is never called? Best to do that in afterEach. Check out the restoreGetBoundingClientRect and how it's used.