Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radar-chart): apply className to the RadarChart component #4334

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

108yen
Copy link
Contributor

@108yen 108yen commented Mar 22, 2024

Description

apply className to the RadarChart component

Related Issue

#4333

Motivation and Context

Required if you want to assign className to the RadarChart component.

How Has This Been Tested?

Checked in storybook and passed existing tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or extended an existing story to show my changes

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (8a0b5a8) to head (3801f04).
Report is 7 commits behind head on 3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.x    #4334      +/-   ##
==========================================
+ Coverage   94.95%   94.97%   +0.02%     
==========================================
  Files          93       95       +2     
  Lines       20187    20290     +103     
  Branches     2821     2825       +4     
==========================================
+ Hits        19168    19271     +103     
  Misses       1013     1013              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ckifer
Copy link
Member

ckifer commented Mar 24, 2024

can you do the same for this one?

@108yen
Copy link
Contributor Author

108yen commented Mar 25, 2024

@ckifer
Updated!

Copy link
Member

@ckifer ckifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ckifer ckifer merged commit f8101d4 into recharts:3.x Mar 25, 2024
5 checks passed
@108yen 108yen deleted the feat/radar-chart branch March 25, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants