chore: upgrade react, react types, test deps in devDependencies

[ckifer]

Description

upgrade dev deps. Specifically react types for longer term fix to linked issue

also upgrade:

• react (used in demo and what we're testing against technically)
• react-dom
• jsdom
• @testing-library/jest-dom
• @testing-library/react
• @testing-library/user-event

Some changes needed to be made to tests including legacyRoot in certain places to prevent failing tests in general.
ReactNode now includes ReactPortal and Iterator<ReactNode>

Related Issue

#4382

Motivation and Context

• trying to get ahead of dependency upgrades for 3.x, uncovers some issues in our tests

How Has This Been Tested?

npm test, chromatic build

https://www.chromatic.com/build?appId=63da8268a0da9970db6992aa&number=894

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• deps

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• I have added a storybook story or extended an existing story to show my changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.33%. Comparing base (ee93c54) to head (b785e3d).

Additional details and impacted files

@@           Coverage Diff           @@
##              3.x    #4474   +/-   ##
=======================================
  Coverage   95.32%   95.33%           
=======================================
  Files         111      111           
  Lines       21305    21306    +1     
  Branches     2937     2944    +7     
=======================================
+ Hits        20310    20313    +3     
+ Misses        989      987    -2     
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[PavelVanecek]

I wonder if it'svaluable to test multiple React versions.

[ckifer]

Probably but how 😅