Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guard against accidental undefined access in Brush #4504

Merged
merged 1 commit into from
May 8, 2024

Conversation

ckifer
Copy link
Member

@ckifer ckifer commented May 8, 2024

Description

Fix brush bug experienced in current release, guard against it in 3.x too

Related Issue

This is interesting... not sure why people use Brush like this? Asked for a reason in the comment
#2093 (comment)

Motivation and Context

bug prevention

How Has This Been Tested?

it hasn't really, but it doesn't hurt anything

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or extended an existing story to show my changes

@ckifer ckifer requested a review from PavelVanecek May 8, 2024 05:30
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (3.x@8b67483). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             3.x    #4504   +/-   ##
======================================
  Coverage       ?   95.42%           
======================================
  Files          ?      111           
  Lines          ?    21559           
  Branches       ?     2985           
======================================
  Hits           ?    20572           
  Misses         ?      981           
  Partials       ?        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ckifer
Copy link
Member Author

ckifer commented May 8, 2024

nothing really to review here, gonna ship it

@ckifer ckifer merged commit dea3b29 into 3.x May 8, 2024
10 of 11 checks passed
@ckifer ckifer deleted the fix/brush-access branch May 8, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant