Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pre-chorus in .txt format #17

Closed
fartleako opened this issue Jun 22, 2023 · 2 comments
Closed

Support for pre-chorus in .txt format #17

fartleako opened this issue Jun 22, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@fartleako
Copy link

Currently, a pre-chorus is not supported with the ccli song format. If you change it to a .song format it works fine.

The pre-chorus should be displayed before the chorus itself.

  • OS: Windows
  • Version 2.4.0

To try it out yourself, you can open up the included file below. You will see that the pre-chorus is not displayed (just verse 1 - chorus - verse 2).

Lorem ipsum dolor.txt

@reckel-jm reckel-jm added the bug Something isn't working label Jul 20, 2023
reckel-jm added a commit that referenced this issue Jul 20, 2023
@reckel-jm
Copy link
Owner

Thanks for posting! cdd34c5 implements a fix which produces the desired outcome:

#ccli-songnumber: 000000
#author: Lorem Ipsum
#ccli-licensenumber: 000000

Lorem ipsum dolor sit amet, 
consetetur sadipscing elitr, 
sed diam

Missing Pre-Chorus
Missing Pre-Chorus

eirmod tempor invidunt ut labore 
et dolore magna aliquyam
eirmod tempor invidunt ut labore 
et dolore magna aliquyam

erat, sed diam voluptua. 
At vero eos et accusam et
sed diam

Missing Pre-Chorus
Missing Pre-Chorus

eirmod tempor invidunt ut labore 
et dolore magna aliquyam
eirmod tempor invidunt ut labore 
et dolore magna aliquyam      

@reckel-jm
Copy link
Owner

The issue is solved and therefore can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants