Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong display of presentation when no specific font has been selected #24

Closed
reckel-jm opened this issue Mar 30, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@reckel-jm
Copy link
Owner

Describe the bug
User @fartleako has reported that on Windows 11 there seems to be an error of displaying songs when no specific font has been selected in the settings.

To Reproduce
Steps to reproduce the behavior (if known):

  1. Run Cantara without specific font configuration
  2. Select a song
  3. Start the presentation

Expected behavior
The lyrics should not be cropped like they are in the screenshot.

Screenshots
grafik

Information about your Operation System (please complete the following information):

  • OS: Windows 11
  • Installation Method: Winget
  • Version 2.5.0
@reckel-jm
Copy link
Owner Author

Diagnosis: It seems that the calculation of the vertical font size for the surrounding TextRect leads to wrong results if no font is specified and the system default is going to be used. In order to change that, I will hard code 'Arial' as the default if no specific font has been set.

reckel-jm added a commit that referenced this issue Mar 30, 2024
@reckel-jm
Copy link
Owner Author

1daffb2 should fix the problem. I will test it on Windows and then close the issue.

@reckel-jm reckel-jm self-assigned this Mar 30, 2024
@reckel-jm reckel-jm added the bug Something isn't working label Mar 30, 2024
@reckel-jm reckel-jm added this to the 2.6 milestone Mar 30, 2024
@reckel-jm
Copy link
Owner Author

Hello @fartleako,
I have tested it under Windows 11 (the only Windows I have access to at the moment) and there has been no problems in display. See the picture below. I'll mark the topic as solved for now.
If any problems still arise, feel free to open it again.
Alles, was ihr tut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant