-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails with Python 3.4 #83
Comments
+1 |
1 similar comment
+1 |
same problem here, using python 3.5 |
Seeing this in py3.5 and py3.6 using 0.4.13 |
Digging into this a little bit, the problem seems to be that the item being unpickled in py3 was pickled with py2. It looks like |
+1 |
Are we going to get a new release that includes this fix? |
A better fix would be to catch pickle / any errors, log a warning (once?), and then perform the request as if the cache entry never existed. That'll auto-heal any incompatibilities, assuming you do not access the same store with different version combinations. |
Yes, that would be much better! |
Has this issue been fixed? |
No. I've abandoned this package, as it appears unmaintained and doesn't support Python3. |
@chrisspen FYI, this issue has been fixed as of 0.5.2. Also, this package is being maintained again. The next release (0.6) will support only current python versions (3.6+); see issue #171. |
If I attempt to use requests with caching enabled in Python 3.4, I get this traceback:
As far as I can tell, dummy_thread is a Python 2.7 module, which doesn't exist in Python 3.*, so I'm not sure what would be trying to use it, much less for retrieving URLs.
The text was updated successfully, but these errors were encountered: