fix: cast items recycler (finally) (#564)

* turn cast items visible(tools) * prevent cast gesture listener from permanent RIP in one lifecycle
recloudstream · Aug 18, 2023 · e95dc1d · e95dc1d
1 parent 8f6e8a8
commit e95dc1d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 13 deletions.
diff --git a/app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultFragmentPhone.kt b/app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultFragmentPhone.kt
@@ -212,19 +212,17 @@ open class ResultFragmentPhone : FullScreenPlayer() {
         loadTrailer()
     }
 
-    override fun onDestroy() {
-        super.onDestroy()
-        PanelsChildGestureRegionObserver.Provider.get().apply {
-            resultBinding?.resultCastItems?.let {
-                unregister(it)
-            }
-            removeGestureRegionsUpdateListener(gestureRegionsListener)
-        }
-    }
-
     override fun onDestroyView() {
+
         //somehow this still leaks and I dont know why????
         // todo look at https://github.com/discord/OverlappingPanels/blob/70b4a7cf43c6771873b1e091029d332896d41a1a/sample_app/src/main/java/com/discord/sampleapp/MainActivity.kt
+        PanelsChildGestureRegionObserver.Provider.get().let { obs ->
+            resultBinding?.resultCastItems?.let {
+                obs.unregister(it)
+            }
+
+            obs.removeGestureRegionsUpdateListener(gestureRegionsListener)
+        }
 
         updateUIEvent -= ::updateUI
         binding = null
@@ -1127,4 +1125,4 @@ open class ResultFragmentPhone : FullScreenPlayer() {
             }
         }
     }
-}
+}
diff --git a/app/src/main/res/layout/fragment_result.xml b/app/src/main/res/layout/fragment_result.xml
@@ -476,7 +476,7 @@
                         app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
                         tools:itemCount="2"
                         tools:listitem="@layout/cast_item"
-                        tools:visibility="gone" />
+                        tools:visibility="visible" />
 
                     <TextView
                         android:id="@+id/result_vpn"
@@ -905,4 +905,4 @@
                 android:contentDescription="@string/search_poster_descript"/>
     </androidx.cardview.widget.CardView>-->
 
-</FrameLayout>
+</FrameLayout>