[Feature] Automatically download plugin, based on language setting #172
Conversation
|
ngl i don't like that you're forcing users to download all the plugins of a given language w/o any option to prevent it |
Its only if 'Auto update plugin' is on |
it should be a separate setting |
|
That's doable. Though I'd argue that updating plugins is the same as downloading missing ones. And less processing time for the user |
its not the same (eg it would force me to download all english movie providers when i use one or two) |
Jacekun
force-pushed
the
autoDownload
branch
3 times, most recently
from
d45c900
to
423aefa
Compare
|
🤨 |
Whenever a new extension is added to my repo, I wanna have my cloudstream to download it. More plugins = more options = less overload. |
app/src/main/java/com/lagradost/cloudstream3/plugins/PluginManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/plugins/PluginManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/plugins/PluginManager.kt
Outdated
Show resolved
Hide resolved
|
Looks good, I will test it later today 👍 |
|
Looks good 🙏 |
app/src/main/java/com/lagradost/cloudstream3/plugins/PluginManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/plugins/PluginManager.kt
Outdated
Show resolved
Hide resolved
Jacekun
force-pushed
the
autoDownload
branch
from
0e97eab
to
c90718f
Compare
|
Salut |
…n language setting.
…ate setting for it.
…checking for plugin updates.
Jacekun
force-pushed
the
autoDownload
branch
from
93d4d92
to
7514a9e
Compare
|
@LagradOst you have one day to object before i merge 👍 |
| //Omit NSFW, if disabled | ||
| sitePlugin.tvTypes?.let { tvtypes -> | ||
| if (!settingsForProvider.enableAdult) { | ||
| if (tvtypes.contains(TvType.NSFW.name)) { |
There was a problem hiding this comment.
pretty much everything is great besides unnecessary nested if statements here
if (!settingsForProvider.enableAdult && tvtypes.contains(TvType.NSFW.name)) {
does the same 🙏
There was a problem hiding this comment.
Micro optimization. If the toggle is off, no need to check if tvtype contains the NSFW type.
There was a problem hiding this comment.
No, the compiler already does that, && stuff is not executed fully if it can quit early
|
|
Hey, I'm new to this. Can you please help me with cloud storage repositories? |
Todo: Waiting for setting re- implementationReady for merge.