Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for different preferred watch quality for data and wifi #376

Open
3 tasks done
imDusht opened this issue Feb 16, 2023 · 5 comments
Open
3 tasks done

Option for different preferred watch quality for data and wifi #376

imDusht opened this issue Feb 16, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@imDusht
Copy link

imDusht commented Feb 16, 2023

Describe your suggested feature

I prefer watching in 720p on wifi but 480p on data, so always have to change it manually
If preferred video quality for both can be selected seperately then it would be much better

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@imDusht imDusht added the enhancement New feature or request label Feb 16, 2023
@allenbaby
Copy link
Contributor

@LagradOst Hey, is this a good first issue? Can I pick this up?

@LagradOst
Copy link
Contributor

yes @allenbaby go for it, should be easy to do

@allenbaby
Copy link
Contributor

yes @allenbaby go for it, should be easy to do

Great! Let me see what I can do :)

@allenbaby
Copy link
Contributor

@LagradOst Hello, so I've done this development and has been testing the functionality in different devices and noticed that when I used the fun Context.isUsingMobileData(): Boolean { } already there in the app, it was not working on my phone but works on the emulator. So I've tried a different approach with Settings.Global.getInt(getApplicationContext().getContentResolver(), "mobile_data", 0) == 1 which basically checks if the mobile-data toggle in android is turned "ON" and is working on emulator and phone. Which one do you think should be the ideal solution, or do you want me to go through with a different approach?

@allenbaby
Copy link
Contributor

Both of them have the drawback of not checking current connection source. If mobile data is turned on while using Wifi both functions returns true regardless.

allenbaby added a commit to allenbaby/cloudstream that referenced this issue Feb 24, 2023
Blatzar pushed a commit that referenced this issue Feb 24, 2023
…ta. (#391)

* Issue #376: Added new feature for separate watch quality on mobile data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants