Warn of potential duplicates when adding to library

[Luna712]

• Resolves Duplicate title warning when adding a title to library (from another source) #622
• Resolves Utilize IMDb ID when available when saving items to the library #684

[Luna712]

• TODO: Utilize IMDb ID when available when saving items to the library #684, but for now this is ready for review

This might be a very messy way to do this and might be much better ways, but I'm not sure. If this is a total mess, I apologize.

[Luna712]

I updated this to be much more clean (in my opinion) by reducing duplicate code through use of better callbacks, and cleaning up messages in dialog to be more clear also.

[Luna712]

I've tested almost every possibility I can think of on both TV and Phone for Subscriptions, Favorites, and each and every bookmark option (both in viewer and homepage preview), but there is still a chance I missed something. This works pretty consistently and accurately from my observations.

[Luna712]

This now does the IMDb ID checking support as well.

[fire-light42]

Very nice 👍, however it is not very futureproof nor support any other service than imdb

[Luna712]

Very nice 👍, however it is not very futureproof nor support any other service than imdb

Thanks for your review!
Though, this does support even if not using Imdb, it then checks if title is an exact match, could support tmdb but I though that might complicate it as imdb and tmdb would contain fairlt similar stuff so didn't see why we would need to check both.

[fire-light42]

Very nice 👍, however it is not very futureproof nor support any other service than imdb

Thanks for your review! Though, this does support even if not using Imdb, it then checks if title is an exact match, could support tmdb but I though that might complicate it as imdb and tmdb would contain fairlt similar stuff so didn't see why we would need to check both.

the point is not to do overlapping support like tmdb + imdb, but to have support for ANY service and in this case MAL would cover what imdb does not

[Luna712]

Very nice 👍, however it is not very futureproof nor support any other service than imdb

Thanks for your review! Though, this does support even if not using Imdb, it then checks if title is an exact match, could support tmdb but I though that might complicate it as imdb and tmdb would contain fairlt similar stuff so didn't see why we would need to check both.

the point is not to do overlapping support like tmdb + imdb, but to have support for ANY service and in this case MAL would cover what imdb does not

I understand, the issue I ran into supporting all syncData is Imdb is in simkl as a text of both tmdb and imdb, parsing through this while supporting non-simkl values makes the code much more complicated and I couldn't really figure it out. I'll try some more though.

[Luna712]

Very nice 👍, however it is not very futureproof nor support any other service than imdb

@fire-light42

Thanks again for the review, I think I got everything now!

[fire-light42]

🙏 This is much better, but I would still like to see mal, anilist and tmdb id check before merge

[Luna712]

🙏 This is much better, but I would still like to see mal, anilist and tmdb id check before merge

Thanks again, done!

[fire-light42]

Minor code quality things then merge. I am somewhat extra strict here with performance as we don't want a 300ms or so delay when clicking just because we have 1000 items in our library

[Luna712]

Minor code quality things then merge. I am somewhat extra strict here with performance as we don't want a 300ms or so delay when clicking just because we have 1000 items in our library

Thanks, and I appreciate that. It should be done again now.

[fire-light42]

When testing this I found 2 UX issues

1. We just want to match on duplicates no matter the status. This might have been my confusing comment about it 3 days ago that made you change it, but just write smth like
   fun getAllBookmarkedData(): List<BookmarkedData> = getKeys("$currentAccount/$RESULT_WATCH_STATE_DATA")?.mapNotNull(::getKey) ?: emptyList()
2. We only want to do the check when the watch status when it goes from None -> something else, we have already confirmed that we want a series bookmarked if we have on watching and move it to dropped for example.

Other than that it looks fine 👍 good job.

[Luna712]

When testing this I found 2 UX issues

1. We just want to match on duplicates no matter the status. This might have been my confusing comment about it 3 days ago that made you change it, but just write smth like
   fun getAllBookmarkedData(): List<BookmarkedData> = getKeys("$currentAccount/$RESULT_WATCH_STATE_DATA")?.mapNotNull(::getKey) ?: emptyList()
2. We only want to do the check when the watch status when it goes from None -> something else, we have already confirmed that we want a series bookmarked if we have on watching and move it to dropped for example.

Other than that it looks fine 👍 good job.

Got it thanks, I'll finalize that i a couple hours. Sorry about that.

[Luna712]

When testing this I found 2 UX issues

1. We just want to match on duplicates no matter the status. This might have been my confusing comment about it 3 days ago that made you change it, but just write smth like
   fun getAllBookmarkedData(): List<BookmarkedData> = getKeys("$currentAccount/$RESULT_WATCH_STATE_DATA")?.mapNotNull(::getKey) ?: emptyList()
2. We only want to do the check when the watch status when it goes from None -> something else, we have already confirmed that we want a series bookmarked if we have on watching and move it to dropped for example.

Other than that it looks fine 👍 good job.

@fire-light42

I think I got it done, had some issues with how NONE was done, which saved to data regardless (seems like even before it did) so counted as a duplicate but I think I fixed that, and made it remove properly, before it seems like it was removed and immediately readded, which I have no idea if that was intentional or not, but it does not do that anymore. If you want it to, I can figure something else out.

[Luna712]

Thanks again for all your reviewing and suggestions @fire-light42