-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn of potential duplicates when adding to library #691
Conversation
Luna712
commented
Oct 14, 2023
•
edited
Loading
edited
- Resolves Duplicate title warning when adding a title to library (from another source) #622
- Resolves Utilize IMDb ID when available when saving items to the library #684
1a1d728
to
6de8fa1
Compare
6de8fa1
to
e1f833a
Compare
This might be a very messy way to do this and might be much better ways, but I'm not sure. If this is a total mess, I apologize. |
92d525f
to
15ef933
Compare
…pport bookmarks if added from the home page
I updated this to be much more clean (in my opinion) by reducing duplicate code through use of better callbacks, and cleaning up messages in dialog to be more clear also. |
I've tested almost every possibility I can think of on both TV and Phone for Subscriptions, Favorites, and each and every bookmark option (both in viewer and homepage preview), but there is still a chance I missed something. This works pretty consistently and accurately from my observations. |
da47f09
to
9cf0a4f
Compare
9cf0a4f
to
61439eb
Compare
This now does the IMDb ID checking support as well. |
a20e097
to
cec2a09
Compare
8904faa
to
c3fa6c1
Compare
c3fa6c1
to
01ce260
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍, however it is not very futureproof nor support any other service than imdb
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultViewModel2.kt
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultViewModel2.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/utils/DataStoreHelper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/utils/DataStoreHelper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/utils/DataStoreHelper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultViewModel2.kt
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultViewModel2.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultViewModel2.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultViewModel2.kt
Outdated
Show resolved
Hide resolved
Thanks for your review! |
the point is not to do overlapping support like tmdb + imdb, but to have support for ANY service and in this case MAL would cover what imdb does not |
I understand, the issue I ran into supporting all syncData is Imdb is in simkl as a text of both tmdb and imdb, parsing through this while supporting non-simkl values makes the code much more complicated and I couldn't really figure it out. I'll try some more though. |
Thanks again for the review, I think I got everything now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 This is much better, but I would still like to see mal, anilist and tmdb id check before merge
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultViewModel2.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultViewModel2.kt
Outdated
Show resolved
Hide resolved
Thanks again, done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor code quality things then merge. I am somewhat extra strict here with performance as we don't want a 300ms or so delay when clicking just because we have 1000 items in our library
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultViewModel2.kt
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultViewModel2.kt
Outdated
Show resolved
Hide resolved
Thanks, and I appreciate that. It should be done again now. |
When testing this I found 2 UX issues
Other than that it looks fine 👍 good job. |
Got it thanks, I'll finalize that i a couple hours. Sorry about that. |
I think I got it done, had some issues with how NONE was done, which saved to data regardless (seems like even before it did) so counted as a duplicate but I think I fixed that, and made it remove properly, before it seems like it was removed and immediately readded, which I have no idea if that was intentional or not, but it does not do that anymore. If you want it to, I can figure something else out. |
Thanks again for all your reviewing and suggestions @fire-light42 |