-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor (search filter) : syncing main tytype chips and bottom dialog tytype chips #811
Conversation
…ing from bottom dialog chips
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code contains a bug causing the chips to stop working
selectedSearchTypes, | ||
validAPIs.flatMap { api -> api.supportedTypes }.distinct() | ||
) { | ||
// This already handled in another bindChips. Do nothing here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this will break the logic as the callback (button?.setOnCheckedChangeListener
) will be set to Unit and the buttons will stop working. If you want to keep the prev callback make the callback nullable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for another bindchips call. updateChips is already there. using it now. pls chk.
👍 All working fine. Nice small pr! |
changes applicable to search page.