refactor (search filter) : syncing main tytype chips and bottom dialog tytype chips #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 12, 2023 11:43
…ing from bottom dialog chips
ghost
changed the title
ghost
changed the title
fire-light42
requested changes
Dec 13, 2023
| selectedSearchTypes, | ||
| validAPIs.flatMap { api -> api.supportedTypes }.distinct() | ||
| ) { | ||
| // This already handled in another bindChips. Do nothing here! |
There was a problem hiding this comment.
Nope, this will break the logic as the callback (button?.setOnCheckedChangeListener) will be set to Unit and the buttons will stop working. If you want to keep the prev callback make the callback nullable
There was a problem hiding this comment.
no need for another bindchips call. updateChips is already there. using it now. pls chk.
fire-light42
approved these changes
Dec 15, 2023
|
👍 All working fine. Nice small pr! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes applicable to search page.