Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hotfix): bottom sheet appearing when turning biometrics off and remove toast. #971

Merged
merged 3 commits into from
Mar 10, 2024

Conversation

IndusAryan
Copy link
Contributor

this needs some talk in the issue before being undrafted

closes #969

@IndusAryan IndusAryan marked this pull request as ready for review March 8, 2024 16:23
@Luna712
Copy link
Contributor

Luna712 commented Mar 9, 2024

@IndusAryan I wonder if maybe you should have to confirm biometrics before it can even be enabled also? iE enter biometrics once when enabling and if it fails don't actually enable also.

@IndusAryan
Copy link
Contributor Author

this was thought as well as tried, to get this it requires bringing interface onAuthenticationSuccess in the accountSetting, but it requiresActivity() to work and context, but now i have learned context more , will try again.

@Luna712
Copy link
Contributor

Luna712 commented Mar 10, 2024

this was thought as well as tried, to get this it requires bringing interface onAuthenticationSuccess in the accountSetting, but it requiresActivity() to work and context, but now i have learned context more , will try again.

@IndusAryan

This is probably something I could help with if you need/want?

@IndusAryan
Copy link
Contributor Author

i will draft this and push changes you can review them, or co commit them.

@IndusAryan IndusAryan marked this pull request as draft March 10, 2024 12:53
@Luna712
Copy link
Contributor

Luna712 commented Mar 10, 2024

@IndusAryan can we unmark this as draft and do the rest in a separate PR, this is quite important to get merged for me, especially that random toast is pretty annoying as it even appears on TV which doesn't even support biometrics?

@IndusAryan IndusAryan marked this pull request as ready for review March 10, 2024 18:52
@fire-light42 fire-light42 merged commit 81df68e into recloudstream:master Mar 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with biometric authentication (or rather when it is disabled)
3 participants