Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#80 Fixed annotating of the nested not annotatable content #81

Merged
merged 2 commits into from
Mar 29, 2024
Merged

#80 Fixed annotating of the nested not annotatable content #81

merged 2 commits into from
Mar 29, 2024

Conversation

oleksandr-danylchenko
Copy link
Contributor

@oleksandr-danylchenko oleksandr-danylchenko commented Mar 29, 2024 •
edited
Loading

Issue

This PR resolves the #80 issue, where the split of the selection range could happen on the nested not-annotatable element, leading to unexpected annotation range:
image

Changes Made

  • Excluded the nested not annotatable elements from the "split on them" gathering function
  • Improved the styles for the not annotatable elements in the example

Demo

image

@rsimon rsimon merged commit bed5202 into recogito:main Mar 29, 2024
@oleksandr-danylchenko oleksandr-danylchenko deleted the fix-nested-not-annotatable-selection branch March 29, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oleksandr-danylchenko @rsimon