New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cleanlab): set cleanlab n_jobs=1 as default #1059
fix(cleanlab): set cleanlab n_jobs=1 as default #1059
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
+ Coverage 95.20% 95.27% +0.06%
==========================================
Files 117 119 +2
Lines 4381 4440 +59
==========================================
+ Hits 4171 4230 +59
Misses 210 210
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Nice catch! Just a few inline suggestions
Co-authored-by: David Fidalgo <david@recogn.ai>
* fix(cleanlab): set cleanlab n_jobs=1 as default * test: update tests * Apply suggestions from code review Co-authored-by: David Fidalgo <david@recogn.ai> Co-authored-by: David Fidalgo <david@recogn.ai> (cherry picked from commit 04efde8)
* fix(cleanlab): set cleanlab n_jobs=1 as default * test: update tests * Apply suggestions from code review Co-authored-by: David Fidalgo <david@recogn.ai> Co-authored-by: David Fidalgo <david@recogn.ai> (cherry picked from commit 04efde8)
* 'master' of https://github.com/recognai/rubrix: (33 commits) fix(#1045): fix overall precision (#1087) fix(#1081): prevent add records of different task (#1085) fix(#1045): calculate overall precision from overall correct/incorrect in rules (#1086) fix(#924): parse new error format in UI (#1082) fix(#1054): Optimize Long records (#1080) docs(#949): change note to admonition (#1071) fix(#1053): metadata modal position (#1068) fix(#1067): fix rule definition link when no labels are defined (#1069) fix(#1065): 'B' tag for beginning tokens (#1066) feat(#1054): optimize long records view (#1064) feat(#924): parse validation error, including submitted information (#1056) fix(#1058): sort by % data in rules list (#1062) fix(#1050): generalizes entity span validation (#1055) fix: missing Optional import fix(cleanlab): set cleanlab n_jobs=1 as default (#1059) feat(#982): Show filters in labelling rules view (#1038) feat(#932): label models now modify the prediction_agent when calling LabelModel.predict (#1049) fix(#821): Token classifier QA 2 (#1057) ci: fix path filter condition refactor(#924): normalize API error responses (#1031) ...
This PR disable default parallel processing for
cleanlab.pruning.get_noise_indices
that could bring problems or make systems inestables.Most of the times github actions are failing because of this.
See https://github.com/recognai/rubrix/runs/4982205560?check_suite_focus=true as example
Include also commit 6f62dc5