Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cleanlab): set cleanlab n_jobs=1 as default #1059

Merged
merged 3 commits into from Jan 29, 2022

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Jan 28, 2022

This PR disable default parallel processing for cleanlab.pruning.get_noise_indices that could bring problems or make systems inestables.

Most of the times github actions are failing because of this.

See https://github.com/recognai/rubrix/runs/4982205560?check_suite_focus=true as example

Include also commit 6f62dc5

@frascuchon frascuchon self-assigned this Jan 28, 2022
@frascuchon frascuchon added this to In progress in Release via automation Jan 28, 2022
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #1059 (6d2bd56) into master (aad8ad8) will increase coverage by 0.06%.
The diff coverage is 94.57%.

❗ Current head 6d2bd56 differs from pull request most recent head 7a886b2. Consider uploading reports for the commit 7a886b2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
+ Coverage   95.20%   95.27%   +0.06%     
==========================================
  Files         117      119       +2     
  Lines        4381     4440      +59     
==========================================
+ Hits         4171     4230      +59     
  Misses        210      210              
Flag Coverage Δ
pytest 95.27% <94.57%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/commons/es_helpers.py 86.99% <ø> (ø)
src/rubrix/server/commons/settings.py 89.18% <33.33%> (-10.82%) ⬇️
src/rubrix/server/commons/errors/api_errors.py 95.45% <95.45%> (ø)
src/rubrix/server/commons/errors/base_errors.py 97.10% <97.10%> (ø)
...ubrix/labeling/text_classification/label_errors.py 100.00% <100.00%> (ø)
...ubrix/labeling/text_classification/label_models.py 100.00% <100.00%> (ø)
src/rubrix/server/commons/errors/__init__.py 100.00% <100.00%> (ø)
src/rubrix/server/commons/errors/adapter.py 100.00% <100.00%> (ø)
src/rubrix/server/routes.py 100.00% <100.00%> (ø)
src/rubrix/server/server.py 82.97% <100.00%> (+0.37%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d1e575...7a886b2. Read the comment docs.

Copy link
Contributor

@dcfidalgo dcfidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Nice catch! Just a few inline suggestions

src/rubrix/labeling/text_classification/label_errors.py Outdated Show resolved Hide resolved
src/rubrix/labeling/text_classification/label_errors.py Outdated Show resolved Hide resolved
Release automation moved this from In progress to Review Jan 28, 2022
Co-authored-by: David Fidalgo <david@recogn.ai>
@frascuchon frascuchon merged commit 04efde8 into master Jan 29, 2022
Release automation moved this from Review to Done Jan 29, 2022
@frascuchon frascuchon deleted the bugfixes/overrides-default-njobs-parameter branch January 29, 2022 09:21
@frascuchon frascuchon moved this from Done to Release Ready in Release Jan 31, 2022
frascuchon added a commit that referenced this pull request Jan 31, 2022
* fix(cleanlab): set cleanlab n_jobs=1 as default

* test: update tests

* Apply suggestions from code review

Co-authored-by: David Fidalgo <david@recogn.ai>

Co-authored-by: David Fidalgo <david@recogn.ai>
(cherry picked from commit 04efde8)
@frascuchon frascuchon moved this from Release Ready to Closed in Release Jan 31, 2022
frascuchon added a commit that referenced this pull request Jan 31, 2022
* fix(cleanlab): set cleanlab n_jobs=1 as default

* test: update tests

* Apply suggestions from code review

Co-authored-by: David Fidalgo <david@recogn.ai>

Co-authored-by: David Fidalgo <david@recogn.ai>
(cherry picked from commit 04efde8)
dvsrepo added a commit that referenced this pull request Feb 10, 2022
* 'master' of https://github.com/recognai/rubrix: (33 commits)
  fix(#1045): fix overall precision (#1087)
  fix(#1081): prevent add records of different task (#1085)
  fix(#1045): calculate overall precision from overall correct/incorrect in rules (#1086)
  fix(#924): parse new error format in UI (#1082)
  fix(#1054): Optimize Long records (#1080)
  docs(#949): change note to admonition (#1071)
  fix(#1053): metadata modal position   (#1068)
  fix(#1067): fix rule definition link when no labels are defined (#1069)
  fix(#1065): 'B' tag for beginning tokens (#1066)
  feat(#1054):  optimize long records view (#1064)
  feat(#924): parse validation error, including submitted information (#1056)
  fix(#1058): sort by % data in rules list (#1062)
  fix(#1050): generalizes entity span validation (#1055)
  fix: missing Optional import
  fix(cleanlab): set cleanlab n_jobs=1 as default (#1059)
  feat(#982): Show filters in labelling rules view (#1038)
  feat(#932): label models now modify the prediction_agent when calling LabelModel.predict (#1049)
  fix(#821): Token classifier QA 2 (#1057)
  ci: fix path filter condition
  refactor(#924): normalize API error responses (#1031)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release
Approved Release QA
Development

Successfully merging this pull request may close these issues.

None yet

2 participants