Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Text Class] Optimize Long records view *Prioritary* #1054

Closed
3 of 4 tasks
Amelie-V opened this issue Jan 28, 2022 · 11 comments · Fixed by #1064, #1080 or #1114
Closed
3 of 4 tasks

[Text Class] Optimize Long records view *Prioritary* #1054

Amelie-V opened this issue Jan 28, 2022 · 11 comments · Fixed by #1064, #1080 or #1114
Assignees
@leiyre @Amelie-V
Labels
type: enhancement Indicates new feature requests
Projects
Release

Comments

@Amelie-V
Copy link
Member

Amelie-V commented Jan 28, 2022 •
edited

  • Show labels buttons area above the fold.

  • Create Action to open/close on click the full record in the same view

  • Copy "Show full record" "Show less"

  • I would grap the opportunity to update the "View more" "view less" on Metrics modal to "Show more" "Show less" and apply the same style there
@Amelie-V Amelie-V added the type: enhancement Indicates new feature requests label Jan 28, 2022
@Amelie-V Amelie-V added this to Backlog in Release via automation Jan 28, 2022
@Amelie-V Amelie-V self-assigned this Jan 28, 2022
@Amelie-V
Copy link
Member Author

Captura de pantalla 2022-01-28 a las 11 46 35
Captura de pantalla 2022-01-28 a las 11 45 56

@Amelie-V
Copy link
Member Author

@dvsrepo feedback on the copy pliz

@frascuchon frascuchon moved this from Backlog to Planified in Release Jan 31, 2022
leiyre added a commit that referenced this issue Jan 31, 2022
@leiyre
feat(#1054): optimize long records view
a10b9ac 
closes #1054

This PR replaces scrollable record with expand/collapse system, the collapsed record allows to see labels without scroll
@leiyre leiyre mentioned this issue Jan 31, 2022
Merged
Release automation moved this from Planified to Done Jan 31, 2022
frascuchon pushed a commit that referenced this issue Jan 31, 2022
@leiyre
feat(#1054): optimize long records view (#1064)
2e8d102 
* feat:  optimize long records view

* fix break line

* show collapsable records in token classifier

This PR replaces scrollable record with expand/collapse system, the collapsed record allows to see labels without scroll

Closes #1054
@frascuchon frascuchon moved this from Done to Dev deployment in Release Feb 2, 2022
@frascuchon frascuchon reopened this Feb 2, 2022
Release automation moved this from Dev deployment to In progress Feb 2, 2022
@Amelie-V
Copy link
Member Author

Amelie-V commented Feb 2, 2022

@leiyre We should see the entire card between header and footer.
Leave 10 px space more on card top and bottom

leiyre added a commit that referenced this issue Feb 2, 2022
@leiyre
fix(#1054): Optimize Long records
39882e4 
fix #1054
This PR fixes styles and show full record in token classifier
@leiyre leiyre mentioned this issue Feb 2, 2022
Merged
Release automation moved this from In progress to Done Feb 2, 2022
frascuchon pushed a commit that referenced this issue Feb 2, 2022
@leiyre
fix(#1054): Optimize Long records (#1080)
f69df9b 
This PR fixes styles and show full record in token classifier

* fix: Optimize Long records

* change max-height for xxl screens
frascuchon pushed a commit that referenced this issue Feb 2, 2022
@leiyre @frascuchon
fix(#1054): optimize Long records (#1080)
dfca7d7 
This PR fixes styles and show full record in token classifier

* fix: Optimize Long records

* change max-height for xxl screens

(cherry picked from commit f69df9b)
@frascuchon frascuchon moved this from Done to Release Ready in Release Feb 2, 2022
frascuchon added a commit that referenced this issue Feb 2, 2022
@frascuchon
fix(#1054): optimize Long records (#1080)
cc289c0
@frascuchon frascuchon moved this from Release Ready to Closed in Release Feb 2, 2022
frascuchon added a commit that referenced this issue Feb 2, 2022
@frascuchon
fix(#1054): optimize Long records (#1080)
cf00a79 
(cherry picked from commit 451af37)
frascuchon added a commit that referenced this issue Feb 2, 2022
@frascuchon
fix(#1054): optimize Long records (#1080)
fdd797a
@Amelie-V
Copy link
Member Author

Amelie-V commented Feb 3, 2022

@leiyre @frascuchon It has been applied en XL screen and it's nice. I would recommend do the same on laptop 1440x900

@Amelie-V Amelie-V reopened this Feb 3, 2022
@leiyre
Copy link
Member

leiyre commented Feb 4, 2022 •
edited

@Amelie-V some screenshots with the new changes

laptop
Captura de pantalla 2022-02-04 a las 11 48 17

1920 x 1080

Captura de pantalla 2022-02-04 a las 11 56 58

@Amelie-V could you confirm that are ok?

@frascuchon frascuchon added the Epic label Feb 5, 2022
@Amelie-V
Copy link
Member Author

Amelie-V commented Feb 7, 2022 •
edited by leiyre

I confirm it's ok.

Add:

  • Text class + Text2text : Align on top : checkbox + records + state button + menu ...

leiyre added a commit that referenced this issue Feb 7, 2022
@leiyre
fix(#1054): reduce collapsable area in large records for laptop
19a17a4 
fix #1054
frascuchon added a commit that referenced this issue Feb 7, 2022
@frascuchon @leiyre
fix(#1054): reduce collapsable area. Optimize for annotation (#1106)
bbe6307 
* collapsable area 300

* small area 180px

* max height for collapsable area

* collapsable area max for xxl

* adjust px

* collapsable area max height

* record padding

* calc collapsable area with new padding

* set record collapsable height

Co-authored-by: LeireA <leire@recogn.ai>
frascuchon added a commit that referenced this issue Feb 7, 2022
@frascuchon
fix(#1054): reduce collapsable area. Optimize for annotation (#1106)
c37714e
@frascuchon frascuchon moved this from In progress to Release Ready in Release Feb 7, 2022
frascuchon added a commit that referenced this issue Feb 7, 2022
@frascuchon @leiyre
fix(#1054): reduce collapsable area. Optimize for annotation (#1106)
ba329f3 
* collapsable area 300

* small area 180px

* max height for collapsable area

* collapsable area max for xxl

* adjust px

* collapsable area max height

* record padding

* calc collapsable area with new padding

* set record collapsable height

Co-authored-by: LeireA <leire@recogn.ai>
frascuchon added a commit that referenced this issue Feb 7, 2022
@frascuchon @leiyre
fix(#1054): reduce collapsable area. Optimize for annotation (#1106)
784f783 
* collapsable area 300

* small area 180px

* max height for collapsable area

* collapsable area max for xxl

* adjust px

* collapsable area max height

* record padding

* calc collapsable area with new padding

* set record collapsable height

Co-authored-by: LeireA <leire@recogn.ai>
@frascuchon frascuchon moved this from Release Ready to Ready to DEV QA in Release Feb 8, 2022
@Amelie-V
Copy link
Member Author

Amelie-V commented Feb 8, 2022 •
edited by leiyre

  • Error limit Model (view screenshot) in /release Annotation /single label: while i'm pushing on an label to annotate it appears the error toasr
  • Lower the button "show full records" /More height to the record extract
  • Maintain same left padding on explore and annotation mode. (dont maintain checkbox column space on explore)

@Amelie-V
Copy link
Member Author

Amelie-V commented Feb 8, 2022

Captura de pantalla 2022-02-08 a las 12 05 35

leiyre added a commit that referenced this issue Feb 8, 2022
@leiyre
fix(#1054): long records margin adjustment
664396a 
closes #1054

This PR changes margin bottom / top of "Show full record"
@leiyre leiyre mentioned this issue Feb 8, 2022
Closed
leiyre added a commit that referenced this issue Feb 8, 2022
@leiyre
fix(#1054): long records margin adjustment
3ded4b1 
closes #1054

This PR changes margin bottom / top of "Show full record"
@leiyre leiyre mentioned this issue Feb 8, 2022
Merged
Release automation moved this from Ready to DEV QA to Done Feb 8, 2022
frascuchon pushed a commit that referenced this issue Feb 8, 2022
@leiyre
chore(#1054): long records margin adjustment #1114
72fc91d 
This PR changes margin bottom / top of "Show full record"

Closes #1054
@frascuchon frascuchon moved this from Done to Ready to DEV QA in Release Feb 9, 2022
@Amelie-V
Copy link
Member Author

I've just uncheked the fourth task because style seems not updated. (SS)

@Amelie-V
Copy link
Member Author

Captura de pantalla 2022-02-10 a las 15 13 31

@Amelie-V
Copy link
Member Author

@leiyre @frascuchon As this component exists only in NER I dont have pb to move it for the next release with NER stuff

@Amelie-V Amelie-V moved this from Ready to DEV QA to Approved DEV QA in Release Feb 10, 2022
@frascuchon frascuchon moved this from Approved DEV QA to Ready to Release QA in Release Feb 10, 2022
frascuchon added a commit that referenced this issue Feb 10, 2022
@frascuchon @leiyre
fix(#1054): reduce collapsable area. Optimize for annotation (#1106)
48024ba 
* collapsable area 300

* small area 180px

* max height for collapsable area

* collapsable area max for xxl

* adjust px

* collapsable area max height

* record padding

* calc collapsable area with new padding

* set record collapsable height

Co-authored-by: LeireA <leire@recogn.ai>
frascuchon pushed a commit that referenced this issue Feb 10, 2022
@leiyre @frascuchon
chore(#1054): long records margin adjustment #1114
7fc994e 
This PR changes margin bottom / top of "Show full record"

Closes #1054

(cherry picked from commit 72fc91d)
dvsrepo added a commit that referenced this issue Feb 10, 2022
@dvsrepo
Merge branch 'master' of https://github.com/recognai/rubrix
c8bbcee 
* 'master' of https://github.com/recognai/rubrix: (33 commits)
  fix(#1045): fix overall precision (#1087)
  fix(#1081): prevent add records of different task (#1085)
  fix(#1045): calculate overall precision from overall correct/incorrect in rules (#1086)
  fix(#924): parse new error format in UI (#1082)
  fix(#1054): Optimize Long records (#1080)
  docs(#949): change note to admonition (#1071)
  fix(#1053): metadata modal position   (#1068)
  fix(#1067): fix rule definition link when no labels are defined (#1069)
  fix(#1065): 'B' tag for beginning tokens (#1066)
  feat(#1054):  optimize long records view (#1064)
  feat(#924): parse validation error, including submitted information (#1056)
  fix(#1058): sort by % data in rules list (#1062)
  fix(#1050): generalizes entity span validation (#1055)
  fix: missing Optional import
  fix(cleanlab): set cleanlab n_jobs=1 as default (#1059)
  feat(#982): Show filters in labelling rules view (#1038)
  feat(#932): label models now modify the prediction_agent when calling LabelModel.predict (#1049)
  fix(#821): Token classifier QA 2 (#1057)
  ci: fix path filter condition
  refactor(#924): normalize API error responses (#1031)
  ...
dvsrepo added a commit that referenced this issue Feb 10, 2022
@dvsrepo
Merge branch 'master' of https://github.com/recognai/rubrix
8342b51 
* 'master' of https://github.com/recognai/rubrix: (26 commits)
  feat(#1061): unify records results title (#1111)
  refactor(#945): using new search service (#1117)
  fix(#1121):  Adjust search bar width (#1124)
  fix(#945): validate label for single label text classification dataset (#1123)
  docs: fix skweak images (#1120)
  fix(#831): Remove sort field when only one is applied (#1116)
  refactor(#945): add current search aggregations as metrics (#1115)
  chore(#982): extends search area (#1112)
  chore(#1054): long records margin adjustment #1114
  feat(#1063): Token Classifier fine tuning content selection (#1084)
  refactor(#1102): remove "Update Summary" button rules summary (#1110)
  refactor(#945): revert index config for text2text (#1108)
  fix: convert pd.NaT to None for event_timestamp (#1105)
  fix(#1094): return empty list for no predicted_as (#1107)
  docs(#1089): remove pip install elasticsearch from docs (#1104)
  fix(#1054): reduce collapsable area. Optimize for annotation (#1106)
  fix(#945): include default aggregations for text2text (#1097)
  refactor(#1044): include last updated field for sort (#1093)
  fix(#1094): remove computed record fields returned in API results (#1095)
  feat(#1051): keep predictions labels when annotating (#1077)
  ...
@Amelie-V Amelie-V moved this from Ready to Release QA to Approved Release QA in Release Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

@Amelie-V Amelie-V

Labels
type: enhancement Indicates new feature requests
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
3 participants
@frascuchon @leiyre @Amelie-V