Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#984): manage super user workspaces #1268

Merged
merged 14 commits into from Mar 22, 2022
Merged

fix(#984): manage super user workspaces #1268

merged 14 commits into from Mar 22, 2022

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Mar 17, 2022 •
edited

This PR normalize the super users workspaces shown in UI. Also materializes the NO_WORKSPACE workspaces for datasets without workspace.

Missing parts:

  • Disable optiion of create a new workspace for super users
  • Default home should show only private super user datasets instead of all.
  • Super user cannot create new workspaces

Closes #984

@frascuchon frascuchon marked this pull request as draft March 17, 2022 17:15
@frascuchon frascuchon marked this pull request as ready for review March 18, 2022 12:15
@codecov
Copy link

codecov bot commented Mar 18, 2022 •
edited

Codecov Report

Merging #1268 (53eac27) into master (9e11933) will decrease coverage by 0.92%.
The diff coverage is 51.66%.

@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
- Coverage   94.43%   93.51%   -0.93%     
==========================================
  Files         127      129       +2     
  Lines        5591     5671      +80     
==========================================
+ Hits         5280     5303      +23     
- Misses        311      368      +57
Flag Coverage Δ
pytest 93.51% <51.66%> (-0.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/datasets/api.py 100.00% <ø> (ø)
...rver/tasks/text_classification/api/api_labeling.py 0.00% <0.00%> (ø)
.../server/tasks/text_classification/service/model.py 0.00% <0.00%> (ø)
src/rubrix/server/commons/es_wrapper.py 86.66% <33.33%> (-1.80%) ⬇️
src/rubrix/server/datasets/service.py 96.34% <50.00%> (-2.38%) ⬇️
src/rubrix/server/datasets/dao.py 95.09% <66.66%> (-2.80%) ⬇️
...rver/security/auth_provider/local/users/service.py 94.44% <94.44%> (-1.71%) ⬇️
src/rubrix/client/api.py 94.55% <100.00%> (-0.03%) ⬇️
src/rubrix/server/commons/api.py 100.00% <100.00%> (ø)
src/rubrix/server/commons/errors/base_errors.py 92.40% <100.00%> (-1.27%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d0bc55...53eac27. Read the comment docs.

@frascuchon frascuchon added this to In progress in Release via automation Mar 22, 2022
@frascuchon frascuchon added the type: bug Indicates an unexpected problem or unintended behavior label Mar 22, 2022
@frascuchon frascuchon merged commit cd2b5c9 into master Mar 22, 2022
Release automation moved this from In progress to Ready to DEV QA Mar 22, 2022
@frascuchon frascuchon deleted the bugfixes/manage-super-user-workspaces branch March 22, 2022 09:22
@frascuchon frascuchon moved this from Ready to DEV QA to Ready to Release QA in Release Mar 25, 2022
frascuchon added a commit that referenced this pull request Mar 25, 2022
@frascuchon
fix(#984): manage super user workspaces (#1268)
f9865f4 
(cherry picked from commit cd2b5c9)

fix(workspaces): superuser with empty workspace (#1288)

(cherry picked from commit 4b1ab45)

refactor(workspaces): find datasets without workspace for superusers (#1290)

* refactor(workspaces): find datasets without workspace for superusers

* chore: add Optional to owner field definition

(cherry picked from commit 4e2aa1b)
frascuchon added a commit that referenced this pull request Mar 25, 2022
@frascuchon
fix(#984): manage super user workspaces (#1268)
bdba599 
(cherry picked from commit cd2b5c9)

fix(workspaces): superuser with empty workspace (#1288)

(cherry picked from commit 4b1ab45)

refactor(workspaces): find datasets without workspace for superusers (#1290)

* refactor(workspaces): find datasets without workspace for superusers

* chore: add Optional to owner field definition

(cherry picked from commit 4e2aa1b)
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Mar 28, 2022
frascuchon added a commit that referenced this pull request Mar 28, 2022
@frascuchon
fix(#984): manage super user workspaces (#1268)
ef57107 
(cherry picked from commit cd2b5c9)

fix(workspaces): superuser with empty workspace (#1288)

(cherry picked from commit 4b1ab45)

refactor(workspaces): find datasets without workspace for superusers (#1290)

* refactor(workspaces): find datasets without workspace for superusers

* chore: add Optional to owner field definition

(cherry picked from commit 4e2aa1b)
frascuchon added a commit that referenced this pull request Mar 28, 2022
@frascuchon
fix(#984): manage super user workspaces (#1268)
8935588 
(cherry picked from commit cd2b5c9)

fix(workspaces): superuser with empty workspace (#1288)

(cherry picked from commit 4b1ab45)

refactor(workspaces): find datasets without workspace for superusers (#1290)

* refactor(workspaces): find datasets without workspace for superusers

* chore: add Optional to owner field definition

(cherry picked from commit 4e2aa1b)
frascuchon added a commit that referenced this pull request Mar 30, 2022
@frascuchon
fix(#984): manage super user workspaces (#1268)
9b24921 
(cherry picked from commit cd2b5c9)

fix(workspaces): superuser with empty workspace (#1288)

(cherry picked from commit 4b1ab45)

refactor(workspaces): find datasets without workspace for superusers (#1290)

* refactor(workspaces): find datasets without workspace for superusers

* chore: add Optional to owner field definition

(cherry picked from commit 4e2aa1b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcfidalgo dcfidalgo dcfidalgo approved these changes

Assignees
No one assigned
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Workspace] Show all available workspaces for super users
2 participants
@frascuchon @dcfidalgo