Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(workspaces): find datasets without workspace for superusers #1290

Merged

Conversation

frascuchon
Copy link
Member

No description provided.

@frascuchon frascuchon self-assigned this Mar 23, 2022
@frascuchon frascuchon added the area: server Indicates that an issue or pull request is related to the server label Mar 23, 2022
@frascuchon frascuchon added this to In progress in Release via automation Mar 23, 2022
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1290 (5fc0045) into master (2eb5276) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1290      +/-   ##
==========================================
+ Coverage   93.99%   94.06%   +0.07%     
==========================================
  Files         129      129              
  Lines        5808     5813       +5     
==========================================
+ Hits         5459     5468       +9     
+ Misses        349      345       -4     
Flag Coverage Δ
pytest 94.06% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/datasets/model.py 100.00% <100.00%> (ø)
src/rubrix/server/datasets/service.py 97.70% <100.00%> (+1.35%) ⬆️
src/rubrix/server/security/model.py 100.00% <100.00%> (ø)
src/rubrix/server/datasets/dao.py 96.07% <0.00%> (+0.98%) ⬆️
src/rubrix/server/commons/errors/base_errors.py 93.67% <0.00%> (+1.26%) ⬆️
...rver/security/auth_provider/local/users/service.py 97.22% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eb5276...5fc0045. Read the comment docs.

Release automation moved this from In progress to Review OK Mar 23, 2022
@frascuchon frascuchon merged commit 4e2aa1b into master Mar 23, 2022
Release automation moved this from Review OK to Ready to DEV QA Mar 23, 2022
@frascuchon frascuchon deleted the refactor/find-datasets-without-dataset-for-superuser branch March 23, 2022 11:48
@frascuchon frascuchon moved this from Ready to DEV QA to Ready to Release QA in Release Mar 25, 2022
frascuchon added a commit that referenced this pull request Mar 25, 2022
(cherry picked from commit cd2b5c9)

fix(workspaces): superuser with empty workspace (#1288)

(cherry picked from commit 4b1ab45)

refactor(workspaces): find datasets without workspace for superusers (#1290)

* refactor(workspaces): find datasets without workspace for superusers

* chore: add Optional to owner field definition

(cherry picked from commit 4e2aa1b)
frascuchon added a commit that referenced this pull request Mar 25, 2022
(cherry picked from commit cd2b5c9)

fix(workspaces): superuser with empty workspace (#1288)

(cherry picked from commit 4b1ab45)

refactor(workspaces): find datasets without workspace for superusers (#1290)

* refactor(workspaces): find datasets without workspace for superusers

* chore: add Optional to owner field definition

(cherry picked from commit 4e2aa1b)
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Mar 28, 2022
frascuchon added a commit that referenced this pull request Mar 28, 2022
(cherry picked from commit cd2b5c9)

fix(workspaces): superuser with empty workspace (#1288)

(cherry picked from commit 4b1ab45)

refactor(workspaces): find datasets without workspace for superusers (#1290)

* refactor(workspaces): find datasets without workspace for superusers

* chore: add Optional to owner field definition

(cherry picked from commit 4e2aa1b)
frascuchon added a commit that referenced this pull request Mar 28, 2022
(cherry picked from commit cd2b5c9)

fix(workspaces): superuser with empty workspace (#1288)

(cherry picked from commit 4b1ab45)

refactor(workspaces): find datasets without workspace for superusers (#1290)

* refactor(workspaces): find datasets without workspace for superusers

* chore: add Optional to owner field definition

(cherry picked from commit 4e2aa1b)
frascuchon added a commit that referenced this pull request Mar 30, 2022
(cherry picked from commit cd2b5c9)

fix(workspaces): superuser with empty workspace (#1288)

(cherry picked from commit 4b1ab45)

refactor(workspaces): find datasets without workspace for superusers (#1290)

* refactor(workspaces): find datasets without workspace for superusers

* chore: add Optional to owner field definition

(cherry picked from commit 4e2aa1b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: server Indicates that an issue or pull request is related to the server
Projects
No open projects
Release
Approved Release QA
Development

Successfully merging this pull request may close these issues.

None yet

2 participants