Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics are failing when no rb.log/rb.init is applied #1362

Closed
frascuchon opened this issue Mar 31, 2022 · 0 comments · Fixed by #1363
Closed

Metrics are failing when no rb.log/rb.init is applied #1362

frascuchon opened this issue Mar 31, 2022 · 0 comments · Fixed by #1363
Assignees
@frascuchon
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
Release

Comments

@frascuchon
Copy link
Member

Describe the bug
Metric summary does not work in client when no rb.log is applied before.

To Reproduce

from rubrix.metrics.common import text_length

text_length(name="my-dataset") # --> This will fail

Expected behavior
Metric summary should works

Screenshots
N/A

Environment (please complete the following information):

  • OS [e.g. iOS]: macOS
  • Browser [e.g. chrome, safari]: N/A
  • Rubrix Version [e.g. 0.10.0]: 0.13.0
  • ElasticSearch Version [e.g. 7.10.2]: N/A
  • Docker Image (optional) [e.g. rubrix:v0.10.0]: N/A

Additional context
Add any other context about the problem here.
@frascuchon frascuchon added the type: bug Indicates an unexpected problem or unintended behavior label Mar 31, 2022
@frascuchon frascuchon added this to Backlog in Release via automation Mar 31, 2022
@frascuchon frascuchon self-assigned this Mar 31, 2022
@frascuchon frascuchon moved this from Backlog to Planified in Release Mar 31, 2022
frascuchon pushed a commit that referenced this issue Mar 31, 2022
fix(#1362): using active api method instead instance
de1d9a6
@frascuchon frascuchon mentioned this issue Mar 31, 2022
Merged
@frascuchon frascuchon moved this from Planified to In progress in Release Mar 31, 2022
Release automation moved this from In progress to Ready to DEV QA Mar 31, 2022
frascuchon pushed a commit that referenced this issue Mar 31, 2022
fix(#1362): using active api method instead instance (#1363)
0f1d693 
* fix: using active api method instead instance

* refactor: hide api instance

* chore: provide all metrics from module

* chore: using __all__ instead
@frascuchon frascuchon moved this from Ready to DEV QA to Approved DEV QA in Release Apr 1, 2022
frascuchon pushed a commit that referenced this issue Apr 1, 2022
fix(#1362): using active api method instead instance (#1363)
bcf446d 
* fix: using active api method instead instance

* refactor: hide api instance

* chore: provide all metrics from module

* chore: using __all__ instead

(cherry picked from commit 0f1d693)
@frascuchon frascuchon moved this from Approved DEV QA to Ready to Release QA in Release Apr 1, 2022
@dcfidalgo dcfidalgo moved this from Ready to Release QA to Approved Release QA in Release Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1362): using active api method instead instance argilla-io/argilla
1 participant
@frascuchon