fix(#1362): using active api method instead instance #1363

frascuchon · 2022-03-31T10:20:48Z

Fixing problems found after namespace cleaning with metrics.

codecov · 2022-03-31T10:35:45Z

Codecov Report

Merging #1363 (1652bec) into master (bd2f0d0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
+ Coverage   94.21%   94.24%   +0.02%     
==========================================
  Files         129      130       +1     
  Lines        5863     5869       +6     
==========================================
+ Hits         5524     5531       +7     
+ Misses        339      338       -1

Flag	Coverage Δ
pytest	`94.24% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/rubrix/client/api.py	`95.16% <100.00%> (+0.48%)`	⬆️
src/rubrix/metrics/__init__.py	`100.00% <100.00%> (ø)`
src/rubrix/metrics/commons.py	`100.00% <100.00%> (ø)`
src/rubrix/metrics/text_classification/metrics.py	`100.00% <100.00%> (ø)`
src/rubrix/metrics/token_classification/metrics.py	`96.82% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd07e3...1652bec. Read the comment docs.

dcfidalgo

💯 Just one inline comment

src/rubrix/metrics/__init__.py

* fix: using active api method instead instance * refactor: hide api instance * chore: provide all metrics from module * chore: using __all__ instead (cherry picked from commit 0f1d693)

Francisco Aranda added 3 commits March 31, 2022 12:18

fix(#1362): using active api method instead instance

de1d9a6

refactor: hide api instance

0720762

chore: provide all metrics from module

50b2f29

frascuchon requested a review from dcfidalgo March 31, 2022 10:20

frascuchon self-assigned this Mar 31, 2022

frascuchon added this to In progress in Release via automation Mar 31, 2022

dcfidalgo previously approved these changes Mar 31, 2022

View reviewed changes

src/rubrix/metrics/__init__.py Outdated Show resolved Hide resolved

Release automation moved this from In progress to Review OK Mar 31, 2022

chore: using __all__ instead

1652bec

frascuchon dismissed dcfidalgo’s stale review via 1652bec March 31, 2022 12:28

frascuchon requested a review from dcfidalgo March 31, 2022 12:29

dcfidalgo approved these changes Mar 31, 2022

View reviewed changes

frascuchon merged commit 0f1d693 into master Mar 31, 2022

Release automation moved this from Review OK to Ready to DEV QA Mar 31, 2022

frascuchon deleted the bugfixes/metrics-summary branch March 31, 2022 14:49

frascuchon removed this from Ready to DEV QA in Release Apr 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(#1362): using active api method instead instance #1363

fix(#1362): using active api method instead instance #1363

frascuchon commented Mar 31, 2022

codecov bot commented Mar 31, 2022 •

edited

Loading

dcfidalgo left a comment

fix(#1362): using active api method instead instance #1363

fix(#1362): using active api method instead instance #1363

Conversation

frascuchon commented Mar 31, 2022

codecov bot commented Mar 31, 2022 • edited Loading

Codecov Report

dcfidalgo left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 31, 2022 •

edited

Loading