Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong filter count values when loading a dataset with a filter preset #1503

Closed
frascuchon opened this issue May 17, 2022 · 0 comments · Fixed by #1506
Closed

Wrong filter count values when loading a dataset with a filter preset #1503

frascuchon opened this issue May 17, 2022 · 0 comments · Fixed by #1506
Assignees
@leiyre
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
Release

Comments

@frascuchon
Copy link
Member

Describe the bug
Loading a dataset with a predefined filter (from URL) computes wrong filters count values. After clicking the "Refresh" button, the values are calculated properly

To Reproduce
The screenshot below shows a filtered search with 4 results, but the "Predicted as" filter contains 8 values for the "NEGATIVE" label

Expected behavior
Filters should show the correct count value.

Screenshots
Screenshot 2022-05-17 at 13 05 51

Environment (please complete the following information):

  • OS [e.g. iOS]:
  • Browser [e.g. chrome, safari]:
  • Rubrix Version [e.g. 0.10.0]:
  • ElasticSearch Version [e.g. 7.10.2]:
  • Docker Image (optional) [e.g. rubrix:v0.10.0]:

Additional context
Add any other context about the problem here.
@frascuchon frascuchon added the type: bug Indicates an unexpected problem or unintended behavior label May 17, 2022
@frascuchon frascuchon added this to the v0.15.0 milestone May 17, 2022
@frascuchon frascuchon added this to Backlog in Release via automation May 17, 2022
@frascuchon frascuchon moved this from Backlog to Planified in Release May 17, 2022
@frascuchon frascuchon removed this from the v0.15.0 milestone May 18, 2022
leiyre added a commit that referenced this issue May 18, 2022
@leiyre
fix(#1503): Count filter values when loading a dataset with a route q…
8e2e72a 
…uery

fix #1503
This PR includes the route query filters for the filter counter calculation
@leiyre leiyre mentioned this issue May 18, 2022
Merged
@frascuchon frascuchon moved this from Planified to In progress in Release May 18, 2022
@frascuchon frascuchon moved this from In progress to Pending Review in Release May 18, 2022
Release automation moved this from Pending Review to Waiting Release May 18, 2022
frascuchon pushed a commit that referenced this issue May 18, 2022
@leiyre
fix(#1503): Count filter values when loading a dataset with a route q…
172553e 
…uery (#1506)

This PR includes the route query filters for the filter counter calculation
Closes #1503
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release May 19, 2022
frascuchon pushed a commit that referenced this issue May 19, 2022
@leiyre @frascuchon
fix(#1503): Count filter values when loading a dataset with a route q…
43be9b8 
…uery (#1506)

This PR includes the route query filters for the filter counter calculation
Closes #1503

(cherry picked from commit 172553e)
@leiyre leiyre moved this from Ready to Release QA to Approved Release QA in Release May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1503): Count filter values when loading a dataset with a route query argilla-io/argilla
2 participants
@frascuchon @leiyre