Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 'extend_matrix' to the WeakMultiLabel class #1577

Merged
merged 4 commits into from Jun 27, 2022

Conversation

dcfidalgo
Copy link
Contributor

This PR adds the extend_matrix functionality to the MultiClassLabel.

@dcfidalgo dcfidalgo self-assigned this Jun 22, 2022
@dcfidalgo dcfidalgo added this to In progress in Release via automation Jun 22, 2022
@dcfidalgo dcfidalgo linked an issue Jun 22, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1577 (87d9409) into master (604e24e) will increase coverage by 0.05%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##           master    #1577      +/-   ##
==========================================
+ Coverage   95.32%   95.38%   +0.05%     
==========================================
  Files         131      131              
  Lines        6413     6388      -25     
==========================================
- Hits         6113     6093      -20     
+ Misses        300      295       -5     
Flag Coverage Δ
pytest 95.38% <96.96%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rubrix/labeling/text_classification/weak_labels.py 99.37% <96.87%> (+0.03%) ⬆️
src/rubrix/server/server.py 94.44% <100.00%> (+0.10%) ⬆️
src/rubrix/client/datasets.py 97.98% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bf5090...87d9409. Read the comment docs.

Release automation moved this from In progress to Review OK Jun 24, 2022
@dcfidalgo dcfidalgo merged commit 3ccf93b into master Jun 27, 2022
Release automation moved this from Review OK to Waiting Release Jun 27, 2022
@dcfidalgo dcfidalgo deleted the feat/add_extend_matrix_to_multi_label branch June 27, 2022 08:48
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release Jul 6, 2022
frascuchon pushed a commit that referenced this pull request Jul 6, 2022
* make find_dists_and_nearest a static method

* add extend_matrix to WeakMultiLabel

* add tests

* chore: refactor implementation

(cherry picked from commit 3ccf93b)
frascuchon pushed a commit that referenced this pull request Jul 8, 2022
* make find_dists_and_nearest a static method

* add extend_matrix to WeakMultiLabel

* add tests

* chore: refactor implementation

(cherry picked from commit 3ccf93b)
frascuchon pushed a commit that referenced this pull request Jul 8, 2022
* make find_dists_and_nearest a static method

* add extend_matrix to WeakMultiLabel

* add tests

* chore: refactor implementation

(cherry picked from commit 3ccf93b)
@dcfidalgo dcfidalgo moved this from Ready to Release QA to Approved Release QA in Release Jul 8, 2022
frascuchon pushed a commit that referenced this pull request Jul 8, 2022
* make find_dists_and_nearest a static method

* add extend_matrix to WeakMultiLabel

* add tests

* chore: refactor implementation

(cherry picked from commit 3ccf93b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release
Approved Release QA
Development

Successfully merging this pull request may close these issues.

[WeakMultiLabels] Merge with WeakLabels using a 2 dim wl matrix
2 participants