Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TokenClassificationRecord] Add validation for the alignment of tokens and predictions/annotations to the client #1579

Closed
dcfidalgo opened this issue Jun 24, 2022 · 0 comments · Fixed by #1709
Assignees
Labels
type: enhancement Indicates new feature requests
Milestone

Comments

@dcfidalgo
Copy link
Contributor

Is your feature request related to a problem? Please describe.
[Copied from Slack] What I have in mind is creating the list of my TokenClassificationRecord and filtering the ones out which have an issue (what I am getting is an rubrix.api.errors::ValidationError. Cant log my dataset as it has some misalignments due to token missmatch (e.g. subword was labeled as the entity text and the list of tokens doest not reflect that).

Describe the solution you'd like
I would like to be able to drop the ones that would cause a validation error before log by checking the alignment when creating the records in the client.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@dcfidalgo dcfidalgo added the type: enhancement Indicates new feature requests label Jun 24, 2022
@dcfidalgo dcfidalgo self-assigned this Jun 24, 2022
@dcfidalgo dcfidalgo added this to Backlog in Release via automation Jun 24, 2022
@frascuchon frascuchon moved this from Backlog to In progress in Release Jul 19, 2022
@frascuchon frascuchon added this to the v0.17.0 milestone Jul 19, 2022
@frascuchon frascuchon removed this from the v0.17.0 milestone Aug 1, 2022
@frascuchon frascuchon moved this from In progress to Backlog in Release Aug 1, 2022
@frascuchon frascuchon moved this from Backlog to In progress in Release Sep 9, 2022
Release automation moved this from In progress to Waiting Release Sep 9, 2022
@frascuchon frascuchon removed this from Waiting Release in Release Sep 13, 2022
@frascuchon frascuchon added this to the v0.18.0 milestone Sep 13, 2022
@frascuchon frascuchon added the new label Sep 20, 2022
frascuchon added a commit that referenced this issue Sep 27, 2022
frascuchon added a commit that referenced this issue Sep 27, 2022
frascuchon added a commit that referenced this issue Sep 27, 2022
frascuchon added a commit that referenced this issue Sep 27, 2022
frascuchon added a commit that referenced this issue Sep 29, 2022
frascuchon added a commit that referenced this issue Oct 3, 2022
frascuchon added a commit that referenced this issue Oct 4, 2022
)

Closes #1579

(cherry picked from commit 6d82717)

fix: Improve misaligned error message (#1746)
frascuchon added a commit that referenced this issue Oct 5, 2022
)

Closes #1579

(cherry picked from commit 6d82717)

fix: Improve misaligned error message (#1746)
frascuchon added a commit that referenced this issue Oct 5, 2022
)

Closes #1579

(cherry picked from commit 6d82717)

fix: Improve misaligned error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment