Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): provide a dict for record annotations/predictions #1658

Merged
merged 2 commits into from Aug 25, 2022

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Aug 3, 2022

The changes are provided only at the API level, and several annotations/predictions could bring some filter inconsistencies.

We need still to design a solution to process those annotations by the UI and the client modules

Refs: #1630

@frascuchon frascuchon linked an issue Aug 3, 2022 that may be closed by this pull request
@frascuchon frascuchon changed the base branch from refactor/encapsulate_elasticsearch_comunication to feat/accepting-several-predictionsannotations-for-the-same-record August 4, 2022 12:45
@frascuchon frascuchon marked this pull request as draft August 4, 2022 12:45
@frascuchon frascuchon linked an issue Aug 23, 2022 that may be closed by this pull request
@frascuchon frascuchon force-pushed the refactor/records-with-multiple-annotations branch from adb2755 to e9332df Compare August 25, 2022 11:17
@frascuchon frascuchon changed the base branch from feat/accepting-several-predictionsannotations-for-the-same-record to master August 25, 2022 11:17
@frascuchon frascuchon added this to In progress in Release via automation Aug 25, 2022
@frascuchon frascuchon marked this pull request as ready for review August 25, 2022 11:18
@frascuchon frascuchon force-pushed the refactor/records-with-multiple-annotations branch from e9332df to 76e1ebf Compare August 25, 2022 11:21
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Base: 95.41% // Head: 95.39% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (b661f8d) compared to base (b9e7562).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1658      +/-   ##
==========================================
- Coverage   95.41%   95.39%   -0.03%     
==========================================
  Files         145      145              
  Lines        6634     6660      +26     
==========================================
+ Hits         6330     6353      +23     
- Misses        304      307       +3     
Flag Coverage Δ
pytest 95.39% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/daos/backend/mappings/helpers.py 98.48% <100.00%> (+0.15%) ⬆️
src/rubrix/server/daos/models/records.py 95.04% <100.00%> (+1.29%) ⬆️
src/rubrix/server/daos/records.py 98.03% <100.00%> (-0.04%) ⬇️
...ubrix/labeling/text_classification/label_errors.py 86.74% <0.00%> (-3.62%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frascuchon frascuchon merged commit 6a612ac into master Aug 25, 2022
@frascuchon frascuchon deleted the refactor/records-with-multiple-annotations branch August 25, 2022 14:54
Release automation moved this from In progress to Waiting Release Aug 25, 2022
@frascuchon frascuchon removed this from Waiting Release in Release Sep 13, 2022
@frascuchon frascuchon added this to the v0.18.0 milestone Sep 13, 2022
frascuchon added a commit that referenced this pull request Sep 27, 2022
* feat(API): provide a dict for record annotations/predictions

* tests: fixing partial compatible data model helpers

(cherry picked from commit 6a612ac)
frascuchon added a commit that referenced this pull request Sep 27, 2022
* feat(API): provide a dict for record annotations/predictions

* tests: fixing partial compatible data model helpers

(cherry picked from commit 6a612ac)
frascuchon added a commit that referenced this pull request Sep 27, 2022
* feat(API): provide a dict for record annotations/predictions

* tests: fixing partial compatible data model helpers

(cherry picked from commit 6a612ac)
frascuchon added a commit that referenced this pull request Sep 29, 2022
* feat(API): provide a dict for record annotations/predictions

* tests: fixing partial compatible data model helpers

(cherry picked from commit 6a612ac)
frascuchon added a commit that referenced this pull request Oct 3, 2022
* fix: align agents for predictions annotations

* fix: empty agent for annotations dict but check it on single annotation
frascuchon added a commit that referenced this pull request Oct 3, 2022
* fix: align agents for predictions annotations

* fix: empty agent for annotations dict but check it on single annotation
frascuchon added a commit that referenced this pull request Oct 3, 2022
* feat(API): provide a dict for record annotations/predictions

* tests: fixing partial compatible data model helpers

(cherry picked from commit 6a612ac)

* fix: align agents for predictions annotations

* fix: empty agent for annotations dict but check it on single annotation
frascuchon added a commit that referenced this pull request Oct 5, 2022
* feat(API): provide a dict for record annotations/predictions

* tests: fixing partial compatible data model helpers

(cherry picked from commit 6a612ac)

* fix: align agents for predictions annotations

* fix: empty agent for annotations dict but check it on single annotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accepting several predictions/annotations for the same record
1 participant