Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update progress bar when refreshing after adding new records #1666

Merged
merged 5 commits into from Aug 22, 2022

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented Aug 8, 2022

closes #1590

this PR forces "Refresh" button to update progress metrics

closes #1590

this PR forces "Refresh" button to update progress metrics
@leiyre leiyre requested a review from frascuchon August 8, 2022 08:36
@leiyre leiyre linked an issue Aug 8, 2022 that may be closed by this pull request
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird behavior validating token classification records. After validate some records, the refresh button reset the counter to the initial state. See the gif

compute-wrong-metrics

globalResults aggregations and total should be updated after clicking the refresh button
@leiyre leiyre requested a review from frascuchon August 19, 2022 10:48
@frascuchon frascuchon force-pushed the releases/0.x branch 13 times, most recently from 4e61826 to 5fa7fc3 Compare August 22, 2022 11:44
@frascuchon frascuchon merged commit 884b8c5 into releases/0.x Aug 22, 2022
@frascuchon frascuchon deleted the bugfixes/refresh_update_progress_bar branch August 22, 2022 11:52
frascuchon pushed a commit that referenced this pull request Aug 22, 2022
)

this PR forces "Refresh" button to update progress metrics

Closes #1590
frascuchon pushed a commit that referenced this pull request Aug 22, 2022
)

this PR forces "Refresh" button to update progress metrics

Closes #1590
frascuchon pushed a commit that referenced this pull request Aug 22, 2022
)

this PR forces "Refresh" button to update progress metrics

Closes #1590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Progress Metrics] Not updated when pressing "Refresh"
2 participants