Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Client): validate token classification annotations in client #1709

Merged
merged 35 commits into from Sep 9, 2022

Conversation

frascuchon
Copy link
Member

Closes #1579

This PR includes the changes implemented in #1611 with all conflicts resolved. @dcfidalgo we will merge this one so you don't need to resolve the conflicts.

@frascuchon frascuchon changed the title feat(Client): validate token classification annotations in client #1671 feat(Client): validate token classification annotations in client Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Base: 95.68% // Head: 95.66% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (06edaee) compared to base (96be2d4).
Patch coverage: 95.40% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1709      +/-   ##
==========================================
- Coverage   95.68%   95.66%   -0.02%     
==========================================
  Files         145      147       +2     
  Lines        6677     6720      +43     
==========================================
+ Hits         6389     6429      +40     
- Misses        288      291       +3     
Flag Coverage Δ
pytest 95.66% <95.40%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/client/models.py 93.78% <75.00%> (-4.80%) ⬇️
src/rubrix/__init__.py 100.00% <100.00%> (ø)
src/rubrix/client/datasets.py 97.66% <100.00%> (+0.01%) ⬆️
...brix/server/apis/v0/models/token_classification.py 100.00% <100.00%> (ø)
...ver/services/tasks/token_classification/metrics.py 100.00% <100.00%> (ø)
...erver/services/tasks/token_classification/model.py 99.00% <100.00%> (+0.89%) ⬆️
src/rubrix/utils/__init__.py 100.00% <100.00%> (ø)
src/rubrix/utils/span_utils.py 100.00% <100.00%> (ø)
src/rubrix/utils/utils.py 100.00% <100.00%> (ø)
...ubrix/labeling/text_classification/label_errors.py 90.36% <0.00%> (+3.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frascuchon frascuchon merged commit 6d82717 into master Sep 9, 2022
@frascuchon frascuchon deleted the feat/validate_token_class_annotations_in_client branch September 9, 2022 13:25
frascuchon added a commit that referenced this pull request Sep 27, 2022
frascuchon added a commit that referenced this pull request Sep 27, 2022
frascuchon added a commit that referenced this pull request Sep 27, 2022
frascuchon added a commit that referenced this pull request Sep 27, 2022
frascuchon added a commit that referenced this pull request Sep 29, 2022
frascuchon added a commit that referenced this pull request Oct 3, 2022
frascuchon added a commit that referenced this pull request Oct 4, 2022
)

Closes #1579

(cherry picked from commit 6d82717)

fix: Improve misaligned error message (#1746)
frascuchon added a commit that referenced this pull request Oct 5, 2022
)

Closes #1579

(cherry picked from commit 6d82717)

fix: Improve misaligned error message (#1746)
frascuchon added a commit that referenced this pull request Oct 5, 2022
)

Closes #1579

(cherry picked from commit 6d82717)

fix: Improve misaligned error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant