Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Configuration] Allow configure max length for metadata fields #1761

Closed
frascuchon opened this issue Mar 25, 2022 · 6 comments · Fixed by #1923
Closed

[Configuration] Allow configure max length for metadata fields #1761

frascuchon opened this issue Mar 25, 2022 · 6 comments · Fixed by #1923
Assignees
@frascuchon
Labels
area: server Indicates that an issue or pull request is related to the server good first issue Indicates a good issue for first-time contributors type: enhancement Indicates new feature requests
Milestone
v1.1.0

Comments

@frascuchon
Copy link
Member

Instead of fixed 128 value, it would be nice to provide a max value (for server) by environment var. See also #1276
@frascuchon frascuchon added type: enhancement Indicates new feature requests area: server Indicates that an issue or pull request is related to the server labels Mar 25, 2022
@frascuchon
Copy link
Member Author

See #1276

@frascuchon frascuchon mentioned this issue May 26, 2022
Closed
@frascuchon frascuchon self-assigned this May 26, 2022
@frascuchon frascuchon transferred this issue from argilla-io/argilla May 26, 2022
@frascuchon
Copy link
Member Author

@davidberenstein1957 @dvsrepo I think this could be this a good first issue...

@davidberenstein1957
Copy link
Member

I agree.

@frascuchon frascuchon added good first issue Indicates a good issue for first-time contributors area: server Indicates that an issue or pull request is related to the server type: enhancement Indicates new feature requests labels Oct 11, 2022
@frascuchon frascuchon transferred this issue from another repository Oct 11, 2022
@frascuchon frascuchon added this to the v1.1.0 milestone Nov 4, 2022
@frascuchon
Copy link
Member Author

The MAX_KEYWORD_LENGTH is used by the client to inform users when fields will be truncated. (see here)

If we plan to configure this parameter as a server environment variable, this client check will be dependent on the connected server and won't be applied

@shahjaidev
Copy link

Suggestion:
let the user input any length fields for uploading to the UI (so he can view it during manual labeling) but choose which fields Elastic Search indexes

@frascuchon
Copy link
Member Author

That is a great feature that we plan to include as part od the datasets setting one, but is a mid term feature.

Thank for the suggestion. Really appreciate it!!!

This was referenced Nov 18, 2022
Closed
Merged
frascuchon added a commit that referenced this issue Nov 22, 2022
@frascuchon
feat: Enable metadata length field config by environment variable (#1923
0ff2de7 
)

Closes #1761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

Labels
area: server Indicates that an issue or pull request is related to the server good first issue Indicates a good issue for first-time contributors type: enhancement Indicates new feature requests
Projects
🚲 Argilla Roadmap
Archived in project
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

feat: Enable metadata length field config by environment variable argilla-io/argilla
4 participants
@frascuchon @ufukhurriyetoglu @shahjaidev @davidberenstein1957