New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add, delete and edit rules from Python client #1884
feat: Add, delete and edit rules from Python client #1884
Conversation
Hi @ufukhurriyetoglu great work. For updating the docs, I suggest the following:
In both cases 1 and 2, test that they are working as expected, and take the opportunity to simplify text if you see the opportunity. |
Not sure if everything is pushed, but some new tests are failing. Could you please take a look https://github.com/argilla-io/argilla/actions/runs/3479400438/jobs/5817898907? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ufukhurriyetoglu could you also take a look at the docs under the reference/webapp. They currently only contain information about weak labelling for text classification and I feel token classification should be added.
https://docs.argilla.io/en/latest/reference/webapp/features.html#weak-labelling
@davidberenstein1957 for the webapp/features I checked the post and it seems related to web UI features. This PR is related to python client and UI does not change. As I understand python side is auto generated, we can check if the added modules reflected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please review my changes, especially for typos.
- Remove output cell from https://docs.argilla.io/en/feat-1855-weak-supervision-rules-python-client/tutorials/notebooks/labelling-textclassification-sklearn-weaksupervision.html#Define-rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! thanks for the review and corrections @dvsrepo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ufukhurriyetoglu, typically after changes a new review should be requested. This looks good on my side.
@frascuchon do you need to take another look? Otherwise please merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments to improve the python reference documentation
See here
Co-authored-by: Francisco Aranda <francisco@recogn.ai>
Co-authored-by: Francisco Aranda <francis@argilla.io>
Co-authored-by: Francisco Aranda <francis@argilla.io>
Co-authored-by: Francisco Aranda <francis@argilla.io>
9733ebb
to
f2ee442
Compare
Codecov ReportBase: 94.59% // Head: 94.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1884 +/- ##
===========================================
- Coverage 94.59% 94.56% -0.03%
===========================================
Files 150 150
Lines 7044 7090 +46
===========================================
+ Hits 6663 6705 +42
- Misses 381 385 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closes #1855