Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NER] Add switch Prediction/annotation #821

Closed
Amelie-V opened this issue Dec 16, 2021 · 15 comments · Fixed by #1009, #1042 or #1057
Closed

[NER] Add switch Prediction/annotation #821

Amelie-V opened this issue Dec 16, 2021 · 15 comments · Fixed by #1009, #1042 or #1057
Assignees
@leiyre @Amelie-V
Labels
type: enhancement Indicates new feature requests
Projects
Release

Comments

@Amelie-V
Copy link
Member

Just like in Text2text show Prediction/annotation in 2 views

  • Prediction by default in explore
  • Annotation by default in annotate
@frascuchon
Copy link
Member

Maybe in this task should be nice to visualize both predictions and annotations in the same view.

@dvsrepo
Copy link
Member

dvsrepo commented Dec 16, 2021

Maybe in this task should be nice to visualize both predictions and annotations in the same view.

Yes!

@Amelie-V
Copy link
Member Author

Propuesta 1: la que esta diseñada en 2 declinación (toggle o checkbox)

  • Poder libremente activar/desactivar Predicciones y Anotaciones en ambas vistas (Explore y Annotate)

Propuesta 2

  • Mostrar un estado por defecto (Predicciones in explore) y solo permitir activar/desactivar el segundo

@Amelie-V
Copy link
Member Author

Captura de pantalla 2021-12-17 a las 12 29 28

@frascuchon
Copy link
Member

Nice design! I am a little afraid that the area to change from prediction to annotation at the entity level is too small.

@Amelie-V
Copy link
Member Author

Tras feedback de Paco:

  • Discutir el interes de tener esa vista en Annotate, o si es solo para Explore
  • Buscar una forma de indicar los errores de predicción (si Pred. distinto Annot. = error)

@frascuchon frascuchon added app type: enhancement Indicates new feature requests labels Jan 13, 2022
@frascuchon frascuchon added this to To do in Release via automation Jan 13, 2022
@frascuchon frascuchon moved this from To do to TODO Release in Release Jan 17, 2022
@leiyre leiyre moved this from Planified to In progress in Release Jan 19, 2022
@leiyre leiyre mentioned this issue Jan 20, 2022
Merged
Release automation moved this from In progress to Done Jan 26, 2022
frascuchon pushed a commit that referenced this issue Jan 26, 2022
@leiyre
feat(#821): token classifier show predictions in explore view (#1009)
aad8ad8 
* add toggle buttons

* fix typo

* toggle prediction/annotation

* show annotation and predictions in exploration

* get explore and annotate components

* entities new styles

* fix lint

* fix margin

* remove agent

* fix reset selected span
@Amelie-V Amelie-V reopened this Jan 26, 2022
Release automation moved this from Done to In progress Jan 26, 2022
@Amelie-V
Copy link
Member Author

Amelie-V commented Jan 26, 2022 •
edited

Here is the QA

  • Aumentar font del tool tip (sketch)

  • No veo las predictions in annotation mode

  • Configurar los colores de los labels para que no estén tanto en tono fluorescentes, tan saturados?

@frascuchon
Copy link
Member

Could we deactivate selection ("rine navi" in the following example) once label menu is displayed and the whole span is selected? @leiyre @Amelie-V what do you think about that?

Screenshot 2022-01-26 at 18 17 21

@frascuchon
Copy link
Member

No veo las predictions in annotation mode

Ten en cuenta que las predicciones sólo aparecen para records que no están validados (es decir, que no tienen predicción). En el caso de tener anotación y predicción, el modo anotación sólo mostraría las anotaciones. Sin embargo, si tienes un record sin validar (status = Default), se pueden ver las predicciones antes guardar/validar.

@Amelie-V
Copy link
Member Author

Is it correct to automatically turn all predictions to annotations when we annotate part of one record?

@Amelie-V
Copy link
Member Author

Captura de pantalla 2022-01-26 a las 22 26 18

Captura de pantalla 2022-01-26 a las 22 26 08

leiyre added a commit that referenced this issue Jan 27, 2022
@leiyre
fix(#821): QA token classifier show predictions in explore view
1b59a8f 
fix #821
This PR adds some styles fixes and adjust, tooltip font size, color less saturated and selection remove when selecting spans
@leiyre leiyre mentioned this issue Jan 27, 2022
Merged
Release automation moved this from In progress to Done Jan 27, 2022
frascuchon pushed a commit that referenced this issue Jan 27, 2022
@leiyre
fix(#821): QA token classifier show predictions in explore view (#1042)
f8e7093 
* fix(#821): QA token classifier show predictions in explore view

fix #821
This PR adds some styles fixes and adjust, tooltip font size, color less saturated and selection remove when selecting spans

* fix lint
@Amelie-V
Copy link
Member Author

Amelie-V commented Jan 27, 2022 •
edited by leiyre

QA 2:

  • Annotation mode : align record checkbox with the first record line (margin changed)
  • Enlarge a bit the tooltip minimum width : give some space between Annot. and X (view ss)
  • Stat in Metrics: To help distinguish Predicted from annotated, I would propose to show label in the same way than in records (Underline/Highlight
  • Add Pred.
  • Enlarge a bit the tooltip minimum width on Prediction inside annotation mode : give some space between Label and X (view ss)
  • Review colors

@Amelie-V
Copy link
Member Author

Captura de pantalla 2022-01-27 a las 21 18 08

@Amelie-V
Copy link
Member Author

Could we deactivate selection ("rine navi" in the following example) once label menu is displayed and the whole span is selected? @leiyre @Amelie-V what do you think about that?

Screenshot 2022-01-26 at 18 17 21

I agree. In the same mood, could we desactivate label selector when we click inside the record without any selection? (SS)

@Amelie-V
Copy link
Member Author

Captura de pantalla 2022-01-27 a las 21 36 55

@leiyre leiyre reopened this Jan 28, 2022
Release automation moved this from Done to In progress Jan 28, 2022
leiyre added a commit that referenced this issue Jan 28, 2022
@leiyre
fix(#821): Token classifier QA 2
1df647a 
fix #821
this PR includes some styling adjustments to the colors, the width of the tooltips, predicted labels visualization in stats... it also includes changes to the register margin and the position of the register checkbox.
@leiyre leiyre mentioned this issue Jan 28, 2022
Merged
Release automation moved this from In progress to Done Jan 28, 2022
frascuchon pushed a commit that referenced this issue Jan 28, 2022
@leiyre
fix(#821): Token classifier QA 2 (#1057)
fb59fec 
This PR includes some styling adjustments to the colors, the width of the tooltips, predicted labels visualization in stats... it also includes changes to the register margin and the position of the register checkbox.

closes #821
@frascuchon frascuchon moved this from Done to Dev deployment in Release Feb 2, 2022
@frascuchon frascuchon reopened this Feb 2, 2022
Release automation moved this from Dev deployment to In progress Feb 2, 2022
dvsrepo added a commit that referenced this issue Feb 10, 2022
@dvsrepo
Merge branch 'master' of https://github.com/recognai/rubrix
c8bbcee 
* 'master' of https://github.com/recognai/rubrix: (33 commits)
  fix(#1045): fix overall precision (#1087)
  fix(#1081): prevent add records of different task (#1085)
  fix(#1045): calculate overall precision from overall correct/incorrect in rules (#1086)
  fix(#924): parse new error format in UI (#1082)
  fix(#1054): Optimize Long records (#1080)
  docs(#949): change note to admonition (#1071)
  fix(#1053): metadata modal position   (#1068)
  fix(#1067): fix rule definition link when no labels are defined (#1069)
  fix(#1065): 'B' tag for beginning tokens (#1066)
  feat(#1054):  optimize long records view (#1064)
  feat(#924): parse validation error, including submitted information (#1056)
  fix(#1058): sort by % data in rules list (#1062)
  fix(#1050): generalizes entity span validation (#1055)
  fix: missing Optional import
  fix(cleanlab): set cleanlab n_jobs=1 as default (#1059)
  feat(#982): Show filters in labelling rules view (#1038)
  feat(#932): label models now modify the prediction_agent when calling LabelModel.predict (#1049)
  fix(#821): Token classifier QA 2 (#1057)
  ci: fix path filter condition
  refactor(#924): normalize API error responses (#1031)
  ...
@frascuchon frascuchon moved this from In progress to Review in Release Feb 17, 2022
@frascuchon frascuchon moved this from Review to Ready to DEV QA in Release Feb 17, 2022
@frascuchon frascuchon moved this from Ready to DEV QA to Approved DEV QA in Release Feb 17, 2022
@frascuchon frascuchon moved this from Approved DEV QA to Ready to Release QA in Release Feb 17, 2022
frascuchon pushed a commit that referenced this issue Feb 17, 2022
@leiyre @frascuchon
feat(#821): token classifier show predictions in explore view (#1009)
6ba6764 
* add toggle buttons

* fix typo

* toggle prediction/annotation

* show annotation and predictions in exploration

* get explore and annotate components

* entities new styles

* fix lint

* fix margin

* remove agent

* fix reset selected span

(cherry picked from commit aad8ad8)
@leiyre leiyre moved this from Ready to Release QA to Approved Release QA in Release Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

@Amelie-V Amelie-V

Labels
type: enhancement Indicates new feature requests
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
4 participants
@dvsrepo @frascuchon @leiyre @Amelie-V