Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Header redesign] Tasks/Modes standardization #970

Closed
1 task done
Amelie-V opened this issue Jan 14, 2022 · 6 comments · Fixed by #1185
Closed
1 task done

[Header redesign] Tasks/Modes standardization #970

Amelie-V opened this issue Jan 14, 2022 · 6 comments · Fixed by #1185
Assignees
@leiyre @Amelie-V
Labels
type: enhancement Indicates new feature requests

Comments

@Amelie-V
Copy link
Member

Amelie-V commented Jan 14, 2022 •
edited by leiyre
Loading

  • Integrate UI presented on 17/02
@Amelie-V Amelie-V added the type: enhancement Indicates new feature requests label Jan 14, 2022
@Amelie-V Amelie-V self-assigned this Jan 14, 2022
@frascuchon frascuchon mentioned this issue Feb 2, 2022
Closed
3 tasks
@frascuchon frascuchon added the Epic label Feb 6, 2022
@Amelie-V Amelie-V changed the title [Header-height] Cross tasks/mode standardization [Header redesign] Tasks/Modes standardization Feb 11, 2022
leiyre pushed a commit that referenced this issue Feb 18, 2022
feat(#970) Header redesign
f0ca4d2
@leiyre leiyre mentioned this issue Feb 18, 2022
Merged
@Amelie-V
Copy link
Member Author

Amelie-V commented Feb 21, 2022 •
edited by leiyre
Loading

Sounds good!
Some comments:

  • Don't see result record number in NER
  • Weak super: I would quit "Records with filters applied (12)" to Records (12)

if its still not so clear maybe I would show a tooltip on the records number (17) inside the rule card: "Filters are not taken into account"

@Amelie-V
Copy link
Member Author

Captura de pantalla 2022-02-21 a las 16 23 19

@Amelie-V
Copy link
Member Author

Amelie-V commented Feb 23, 2022 •
edited by leiyre
Loading

Add disclaimer on records Numb in rules card

  • Only when at least one filter is activated
  • Copy: Filters are not part of the rule, but are applied to the record list below. (rule without R maj)
  • Integrate icon (same color than tooltip) on the same line

@Amelie-V
Copy link
Member Author

Captura de pantalla 2022-02-23 a las 12 27 03

@Amelie-V
Copy link
Member Author

noun-info-3244847

@Amelie-V
Copy link
Member Author

Captura de pantalla 2022-02-23 a las 16 24 27

frascuchon pushed a commit that referenced this issue Feb 24, 2022
feat(#970) header redesign (#1185)
17dffc4 
Closes #970
frascuchon pushed a commit that referenced this issue Mar 3, 2022
chore(#970): avoid collapsing of the filter area when displaying metr…
2bc7a1c 
…ics (#1218)

Closes #1214
frascuchon pushed a commit that referenced this issue Mar 3, 2022
feat(#970): header redesign (#1185)
bc3a1f3 
Closes #970

(cherry picked from commit 17dffc4)

chore(#970): avoid collapsing of the filter area when displaying metrics (#1218)

Closes #1214

(cherry picked from commit 2bc7a1c)
leiyre pushed a commit that referenced this issue Mar 4, 2022
fix(#970): Align metrics position with record
11b17e3 
see #970

This PR fixes metrics position and align it with record start in explore and annotation
@leiyre leiyre mentioned this issue Mar 4, 2022
Merged
frascuchon pushed a commit that referenced this issue Mar 4, 2022
fix(#970): align metrics position with record (#1223)
266e30b 
See #970

This PR fixes metrics position and align it with record start in explore and annotation

* fix Stats title font weight
frascuchon pushed a commit that referenced this issue Mar 4, 2022
feat(#970): header redesign (#1185)
fa9c639 
Closes #970

(cherry picked from commit 17dffc4)

chore(#970): avoid collapsing of the filter area when displaying metrics (#1218)

Closes #1214

(cherry picked from commit 2bc7a1c)

fix(#970): align metrics position with record (#1223)

This PR fixes metrics position and align it with record start in explore and annotation

* fix Stats title font weight

(cherry picked from commit 266e30b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

@Amelie-V Amelie-V

Labels
type: enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#970) Header redesign argilla-io/argilla
3 participants
@frascuchon @leiyre @Amelie-V