Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event grid advanced filtering #331

Merged
merged 5 commits into from
Jun 9, 2023
Merged

Event grid advanced filtering #331

merged 5 commits into from
Jun 9, 2023

Conversation

patrik-pa4k
Copy link
Contributor

@patrik-pa4k patrik-pa4k commented Jun 9, 2023 •
edited by tom-reinders
Loading

Allow the use of advanced filters by adding additional settings to the event grid

CHANGELOG.md:

### Added
- `azure/event_grid_topic_subscription`: Add variable `advanced_filter` (#331) (71e1a5a0) (@patrik-pa4k)

@patrik-pa4k patrik-pa4k requested review from a team and tom-reinders as code owners June 9, 2023 04:41
@patrik-pa4k @tom-reinders
Update modules/azure/event_grid_topic_subscription/variables.tf
42690da 
Co-authored-by: tom-reinders <tom-reinders@users.noreply.github.com>
tom-reinders
tom-reinders requested changes Jun 9, 2023
View reviewed changes
Copy link
Member

@tom-reinders tom-reinders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I may have made it wrong, sorry

modules/azure/event_grid_topic_subscription/variables.tf Outdated Show resolved Hide resolved
modules/azure/event_grid_topic_subscription/main.tf Outdated Show resolved Hide resolved
@patrik-pa4k @tom-reinders
Update modules/azure/event_grid_topic_subscription/main.tf
cc73d92 
Co-authored-by: tom-reinders <tom-reinders@users.noreply.github.com>
@tom-reinders tom-reinders added this to the v3.5.0 milestone Jun 9, 2023
@tom-reinders tom-reinders self-requested a review June 9, 2023 11:28
@tom-reinders tom-reinders merged commit ba4a8d6 into develop Jun 9, 2023
2 checks passed
@tom-reinders tom-reinders deleted the feature/15186-event_grid_advance_filtering branch June 9, 2023 11:36
This was referenced Jun 23, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartwesselink bartwesselink bartwesselink approved these changes

@tom-reinders tom-reinders tom-reinders approved these changes

@ArtiomMatiom ArtiomMatiom Awaiting requested review from ArtiomMatiom

@JeffreyVWT JeffreyVWT Awaiting requested review from JeffreyVWT

@pipalmic pipalmic Awaiting requested review from pipalmic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrik-pa4k @bartwesselink @tom-reinders