Merge branch '63-rmse' into 'master'

Resolve "Evaluation metric: Root mean squared error (RMSE) & related regression metrics" Closes #63 See merge request recommend.games/board-game-recommender!28
recommend-games · May 3, 2023 · 75018d3 · 75018d3
2 parents 65a8365 + 7a1cb88
commit 75018d3
Show file tree

Hide file tree

Showing 2 changed files with 82 additions and 93 deletions.
diff --git a/Pipfile.lock b/Pipfile.lock
diff --git a/board_game_recommender/evaluation.py b/board_game_recommender/evaluation.py
@@ -57,6 +57,7 @@ class RecommenderMetrics:
 
     ndcg: Dict[int, float]
     ndcg_exp: Dict[int, float]
+    rmse: float
 
 
 def calculate_metrics(
@@ -81,6 +82,8 @@ def calculate_metrics(
             + f"shape of predictions ({y_pred.shape})"
         )
 
+    rmse = float(np.sqrt(np.square(y_true - y_pred).mean()))
+
     if k_values is None:
         k_values = frozenset()
     elif isinstance(k_values, int):
@@ -108,4 +111,4 @@ def calculate_metrics(
             k=k,
         )
 
-    return RecommenderMetrics(ndcg=ndcg, ndcg_exp=ndcg_exp)
+    return RecommenderMetrics(ndcg=ndcg, ndcg_exp=ndcg_exp, rmse=rmse)