Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove drop_duplicates() from SAR method #1464

Closed
anargyri opened this issue Jun 28, 2021 · 1 comment
Closed

Remove drop_duplicates() from SAR method #1464

anargyri opened this issue Jun 28, 2021 · 1 comment
Assignees
@anargyri

Comments

@anargyri
Copy link
Collaborator

https://github.com/microsoft/recommenders/blob/efaa3d7742183dee0846877e2dc64977098e1977/reco_utils/recommender/sar/sar_singlenode.py#L232

We may assume that the input data frame has no duplicates, since 90% of the time this has been ensured in prior data prep stages of the data science pipeline.

  • Remove the drop_duplicates() occurrence
  • Update doc string to require input DFs contain no duplicates.
@anargyri anargyri self-assigned this Jun 28, 2021
@anargyri anargyri changed the title Remove drop_duplicates() from SAR methods Remove drop_duplicates() from SAR method Jun 28, 2021
@anargyri
Copy link
Collaborator Author

@simonzhaoms since you are looking into SAR.

miguelgfierro added a commit that referenced this issue Dec 17, 2021
@miguelgfierro
Remove drop_duplicates() from SAR method fix #1464
6aa7d8d
@miguelgfierro miguelgfierro mentioned this issue Dec 17, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anargyri anargyri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anargyri