Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write installation guideline INSTALL.md #69

Closed
yueguoguo opened this issue Oct 16, 2018 · 3 comments
Closed

Write installation guideline INSTALL.md #69

yueguoguo opened this issue Oct 16, 2018 · 3 comments
Assignees
@miguelgfierro
Labels
bug Something isn't working
Milestone
Initial MVP

Comments

@yueguoguo
Copy link
Collaborator

No description provided.

@yueguoguo yueguoguo added the bug Something isn't working label Oct 16, 2018
@yueguoguo yueguoguo added this to the Initial MVP milestone Oct 16, 2018
@yueguoguo yueguoguo changed the title install.sh does not account for PYSPARK_PYTHON environment variable install.sh does not account for PYSPARK_PYTHON environment variable Oct 16, 2018
@miguelgfierro
Copy link
Collaborator

here, instead of doing an installation script, I would suggest to show installation instructions via INSTALL.md in combination with the script to generate conda files and the environment variables.

We can show how to add the environment variables when a user source an environment using activate.d.

Does this make sense?

@yueguoguo
Copy link
Collaborator Author

Fully agree.

@nikhilrj nikhilrj changed the title install.sh does not account for PYSPARK_PYTHON environment variable Write installation guideline INSTALL.md Oct 18, 2018
@nikhilrj
Copy link
Contributor

Also set PYSPARK_DRIVER_PYTHON - it needs to be the same as PYSPARK_PYTHON as per @dciborow

miguelgfierro added a commit that referenced this issue Oct 18, 2018
@miguelgfierro
install md fix #69
fcd3a6f
@miguelgfierro miguelgfierro mentioned this issue Oct 18, 2018
Closed
yueguoguo added a commit that referenced this issue Oct 18, 2018
@yueguoguo
Merge pull request #87 from Microsoft/install
6de7269 
install md fix #69
WessZumino pushed a commit that referenced this issue Nov 28, 2018
@miguelgfierro
install md fix #69
1d6c4db
WessZumino pushed a commit that referenced this issue Nov 28, 2018
@yueguoguo
Merge pull request #87 from Microsoft/install
20dfcd7 
install md fix #69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miguelgfierro miguelgfierro

Labels
bug Something isn't working
Projects
None yet
Milestone
Initial MVP
Development

No branches or pull requests
3 participants
@yueguoguo @miguelgfierro @nikhilrj