Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review problem with Jupyter kernel in the unit tests #75

Closed
miguelgfierro opened this issue Oct 17, 2018 · 5 comments
Closed

Review problem with Jupyter kernel in the unit tests #75

miguelgfierro opened this issue Oct 17, 2018 · 5 comments
Assignees
Milestone

Comments

@miguelgfierro
Copy link
Collaborator

When creating a new cicd system, we had to register a jupyter kernel.

ipykernel install --user --name py36 --display-name "Python (py36)"

python -m ipykernel install --user --name recommender --display-name "Python (recommender)"

We need to review this issue

@yueguoguo
Copy link
Collaborator

@maxkazmsft I thought we have spotted this and you have done some setups on the CICD machine?

@miguelgfierro miguelgfierro self-assigned this Oct 22, 2018
@miguelgfierro
Copy link
Collaborator Author

miguelgfierro commented Oct 22, 2018

When trying to pass the tests, I got this error:

jupyter_client.kernelspec.NoSuchKernel: No such kernel named reco

When executing a notebook with papermill, this is the function:

papermill.tests.test_execute.execute_notebook(input_path, output_path, parameters=None, engine_name=None, prepare_only=False, *, kernel_name='python3', progress_bar=True, log_output=False, start_timeout=60, report_mode=False)

Executes a single notebook locally. :param input_path: Path to input notebook. :type input_path: str :param output_path: Path to save executed notebook. :type output_path: str :param parameters: Arbitrary keyword arguments to pass to the notebook parameters. :type parameters: dict :param prepare_only: Flag to determine if execution should occur or not. :type prepare_only: bool :param kernel_name: Name of kernel to execute the notebook against. :type kernel_name: str :param progress_bar: Flag for whether or not to show the progress bar. :type progress_bar: bool :param log_output: Flag for whether or not to write notebook output_path to stderr. :type log_output: bool :param start_timeout: Duration to wait for kernel start-up. :type start_timeout: int :param report_mode: Flag for whether or not to hide input. :type report_mode: bool

@miguelgfierro miguelgfierro added this to the Early Access milestone Oct 22, 2018
@miguelgfierro
Copy link
Collaborator Author

>>> from jupyter_client.kernelspec import KernelSpecManager 
>>> kk = KernelSpecManager()
>>> kk.find_kernel_specs()
{'python3': '/Users/miguel/anaconda3/envs/reco_bare/share/jupyter/kernels/python3'}

@yueguoguo
Copy link
Collaborator

yueguoguo commented Oct 23, 2018

@miguelgfierro see my response here. I have tried in my own DSVM and it worked well. Let's try on the CICD machine hopefully it resolves our problem.

miguelgfierro added a commit that referenced this issue Oct 23, 2018
miguelgfierro added a commit that referenced this issue Oct 23, 2018
yueguoguo added a commit that referenced this issue Oct 25, 2018
@miguelgfierro
Copy link
Collaborator Author

fixed with #113

WessZumino pushed a commit that referenced this issue Nov 28, 2018
WessZumino pushed a commit that referenced this issue Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants