Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Dockerfile #1058

Merged
merged 1 commit into from
Feb 23, 2020
Merged

fix Dockerfile #1058

merged 1 commit into from
Feb 23, 2020

Conversation

dkozlov
Copy link
Contributor

@dkozlov dkozlov commented Feb 23, 2020

Description

Related Issues

028e004

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging and not master.

@dkozlov
Copy link
Contributor Author

dkozlov commented Feb 23, 2020

@yueguoguo could you please review this change? I am fixing docker build after following commit: 028e004

gramhagen
gramhagen approved these changes Feb 23, 2020
View reviewed changes
Copy link
Collaborator

@gramhagen gramhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks

@gramhagen gramhagen changed the base branch from master to staging February 23, 2020 11:22
@gramhagen
Copy link
Collaborator

Changed to push to staging

@gramhagen gramhagen merged commit c2b55dc into recommenders-team:staging Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramhagen gramhagen gramhagen approved these changes

@miguelgfierro miguelgfierro Awaiting requested review from miguelgfierro miguelgfierro is a code owner

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dkozlov @gramhagen