Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging to master: large refactor, LighGCN and NextItNet #1130

Merged
merged 156 commits into from
Jul 9, 2020
Merged

Staging to master: large refactor, LighGCN and NextItNet #1130

merged 156 commits into from
Jul 9, 2020

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging and not master.

miguelgfierro and others added 30 commits April 16, 2020 11:47
@miguelgfierro
rename and refactor 💥
c47fe4d
@miguelgfierro
rename and refactor 💥
5551d4a
@miguelgfierro
refact
f6b0453
@miguelgfierro
scenarios
6db4148
@miguelgfierro
retail
485c1f1
@miguelgfierro
retail
02bec05
@miguelgfierro
retail
9c35983
@miguelgfierro
retail
3e3756c
@miguelgfierro
retail
7864b8e
@yjw1029
fix attention layer config and lstur user encoder
288a36c
@yjw1029
Merge branch 'v-jinyi/add-news-reco-methods' of https://github.com/yj…
5e05ea1 
…w1029/recommenders into v-jinyi/add-news-reco-methods
@miguelgfierro
comments @yueguoguo
44772c7
@miguelgfierro
Merge branch 'staging' into miguel/burn_and_destroy
d79f878
@yjw1029
change lstur and intergation gpu
9251554
@yjw1029
merge staging
bf9181c
@yjw1029
Merge branch 'microsoft-staging' into v-jinyi/add-news-reco-methods
06637b1
@miguelgfierro
Merge branch 'staging' into miguel/burn_and_destroy
c6c20c5
@weedqian
Replace DataFrameDirectory and ModelDirectory to AnyDirectory.
7ddc27b
@miguelgfierro
Merge pull request #1115 from weedqian/master
28920bf 
Replace DataFrameDirectory and ModelDirectory to AnyDirectory.
@miguelgfierro
advance
5db328f
@miguelgfierro
advance
8eb19fa
@miguelgfierro
advance
f3ddcae
@miguelgfierro
review
f01dcb6
@yjw1029
Merge https://github.com/microsoft/recommenders into v-jinyi/add-news…
de9181f 
…-reco-methods
@miguelgfierro
Update generate_conda_file.py
68f65e7
@miguelgfierro
Update generate_conda_file.py
6b2eed7
@miguelgfierro
remove unused imports
1bfd64f
@miguelgfierro
Merge pull request #1119 from microsoft/miguelgfierro-patch-1
f8cdad6 
Bug with azure storage blob version
@gramhagen
fixing anaconda link in dockerfile (#1120)
c6093e3 
* fixing anaconda link in dockerfile

* Revert conda path removal
@miguelgfierro
Merge branch 'staging' into miguel/burn_and_destroy
c1baf1e
@loomlike
Copy link
Collaborator

loomlike commented Jul 4, 2020

Ok done for py files. General comments:

  1. It would be nice to have better unit-test coverage for the deeprec additions.
  2. Some codes could be more simpler, easier to read and maintain w/ some cleanup techniques, like using a list or dict instead of each repetitive variables, etc.

Thank you!!! 🤟

@miguelgfierro miguelgfierro mentioned this pull request Jul 6, 2020
Open
@miguelgfierro
Copy link
Collaborator Author

miguelgfierro commented Jul 6, 2020 •
edited

hey @loomlike, I started to fix some of the issues. If you have time, feel free to push some of those. Tao suggested closing the PR this week. I'll continue tomorrow

@miguelgfierro miguelgfierro merged commit 839e044 into master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loomlike loomlike loomlike approved these changes

@anargyri anargyri Awaiting requested review from anargyri

@gramhagen gramhagen Awaiting requested review from gramhagen

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet